UI branch - Draft PR

[nostrbuddha]

This PR has the following items done:

1. Splash screen
   1. Loading logic with MVP pattern.
   2. i18n integrated (using lyricist library)
2. Onboarding screen (3 slides)
   1. MVP pattern. But didn't add any models. Since it has static added, hardcoded the data in Presenter only
3. Create Profile: Just the View
4. Bisq URL config screen: Just the view
5. Main page: 4 tabs
6. Getting started / Home / 1st tab
   1. MVP Pattern

All screens goes into /screens
All reusable components in /components
and such.

I am specifically looking for review on how MVP pattern is applied.

Based on feedback, I can keep pushing into this branch. Once it's all good to go, it can then be merged with main.

Thanks.

[rodvar]

@nostrbuddha I'm reviewing this today. For now just added one commit to resolve conflicts with main branch so CI can run and I can download and test, please review when you have a moment.

[rodvar]

CI not building, I'll have a look to see if an easy fix to do a full review, otherwise I'll just focus on pure code review for now till you have a look

* What went wrong:
Execution failed for task ':shared:presentation:compileDebugUnitTestKotlinAndroid'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

[rodvar]

@nostrbuddha Just did a proper rebase of the branch and it works like charm :D

[rodvar]

CI still failing though

AAPT2 aapt2-8.5.0-11315950-linux Daemon #0: shutdown
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':shared:presentation:compileDebugUnitTestKotlinAndroid'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

[rodvar]

UI not passing because androidNode cannot build in this branch, more details coming in the first full review

[rodvar]

Hi @nostrbuddha - I'm stoked with your first UI implementation contribution - great worked!

I just did a first pass on code review and execution and left comments for your to review / discuss. Alongside with that I would like to point out the followings in an attempt to help you organise and make this Pair review work a breeze:

1. As a general comment, your PR is a great contribution on the right direction. You've done a great job integrating your UI work to the base proposed architecture done with a few lines of examples, you've leveraged KMP compose libs first whenever possible, used coroutines when appropiate, and added well structured code. Also you've done more than expected provided foundation for i18n and some networking setup.
2. On that note, CI not building -> this is because this branch breaks the androidNode app. I left you a comment on why this is a happening and how to fix it, its related to ktor dependency -> I suggest we work on this one first
3. I ran the xClients on a real iPhone 10 and android emulators - What a great feeling :D . Something to point out, in my iPhone 10 things are not looking as sharp as in android, with some texts being double lined for example. I think is because of my test device accessibility settings increasing text size, we'll discuss on this on matrix if you agree.
4. This is a first pass and there is quite a bit to work on so I'll leave it here to discuss/work on the stuff and then we'll do a second pass if you agree.

Overal, great job!!! This is very exciting.

[rodvar]

@nostrbuddha this is looking really good, I think the next step would be to rebase your fork branch against bisq-mobile main and do the necessary adaptions to use DI as discussed on matrix.

After that, I'll update my local copy of your branch, test it again in the 3 apps and we'll tweak any small details missing and merge it!

If you have doubts on how to do that or any other questions please reach out on here or directly on chat!

[rodvar]

@nostrbuddha I've installed and tested on the 3 apps and it works amazing even though the build failed in the CI (linux)

I don't have access to a linux machine now, but will do later to verify what's going on there.

In the meantime, runtime-wise this is grea - only issues I could find are very small nuances:

• in iOS rounded buttons and bottom menu buttons break with accessibility changes (probably in android too but I didn't test it) -> they should always keep consistent and grow to a certain size, not break into 2 lines I think) -> we can do this adaptations in a separate accessibility optimizations card
• in Android the app is not taking over all the screen as in iOS (at least not in my pixel6a phone) -> same as above.

Not a deal breaker for this merge, we can report that in individual issues and tackle them with full force later.
So gonna review the code now as requested and put my comments and we can do a final review pass to merge in by the weekend hopefully 💪 great job buddha

[rodvar]

great job @nostrbuddha we are very close now.

The main changes requested in terms of code are

• some missing usages of DI I could spot
• using the new shared repository base classes, and structure to always get / save data to the models in them (otherwise we will loose updates from the network)
• and some minor other changes

I hope you don't find this very tedious, but I consider your PR fundational to the bisq apps as it sets basic "how to's" that will be reused across the UI development of it for the rest of the MVP. Therefore, very important to have it merged right.

As usual, feel free to challenge and question anything I'm reviewing here.

When we finish with this last changes, it's just a matter of doing a final test and making sure it passes the CI (I think it fails because some unintended gradle and pods changes you've commited , once you delete that it will pass :) )

Cheers!!!

[rodvar]

@nostrbuddha we can see the finish line now - please run git pull --rebase on your local branch to grab the updates and then ./gradlew clean build (this one might take a while cause we needed to upgrade gradlew to version 8.11) .

Once you are ready have a look at the last unresolved comments and we are set - go go go! :D

[rodvar]

I guess the question refers to the open ..? Unless there is a really strong inheritance relationship, its better to use composition.

[rodvar]

@nostrbuddha I've committed small nits and the connection between main presenter and the rest of them.

Result is clearly visible now, if you put the app in background and come back it updates the btc price (from Loading to 0 at the moment)

now every presenter needs the main present to be passed as first param, very easy in Koin module context just use get() :)

Gonna test it in iOS and do any changes if necessary - merge is imminent... :D

[rodvar]

@nostrbuddha Also added some swift code for a better onResume() behaviour omn iOS

For the main screen we probably want to call the corresponding onResume() each time the user change tabs? or maybe an specific method - something we need to think about and probably we'll figure out on the next bunch of UI - well done Buddha!