Add domain for user profile

[HenrikJannsen]

No description provided.

[rodvar]

great work @HenrikJannsen

Runtime

• I've tested in android pixel 6 (crashes, but expected from your comments) and in emulator. I'll test in all 3 apps on once this first pass of review gets done
• can get the emulator to run and communicate with running local bisq2-rest-api
• can see the profile creation working in the logs and the screen
• however, I can't go past the screen when clicking next nothing happens and no error is logged
• some other errors seen:

kotlinx.serialization.json.internal.JsonDecodingException: Unexpected JSON token at offset 2: Encountered an unknown key 'error' at path: $`
                                                                                                   Use 'ignoreUnknownKeys = true' in 'Json {}' builder to ignore unknown keys.
                                                                                                   JSON input: {"error":"Could not find a selected user identity"}

Code

I don't wanna be too verbose here, I think when you read my individual comments you'll find the resolution to our discussions. Please reach out if something is not clear.

Regarding the Ktor addition. I was working on this as well but in a separate new networking module in an effort to avoid making the androidModule grasp those dependencies when its not gonna be used.

I think I'll drop that for now until we get this one to be merged and then work on that refactor later on.

I contribute with you by finishing the lifecycle setup so you can reuse in your PR as well, might also include the solution for the Dispatchers.IO for you
cheers!

[rodvar]

@HenrikJannsen done this for you

• Feature/lifecycle polishing #64

you'll probably get conflicts with the CreateProfile screen related code on rebase. I humbly suggest that we keep the presenter view defined interface (you'll see why in the code) but it's up to you for this particular case. cheers!

[HenrikJannsen]

• I can't go past the screen when clicking next nothing happens and no error is logged

I commented out the code to go to next screen in the presenter for dev testing. see comments there. i wanted to test several use cases and as the UI is not yet prepared for that i did it with changing the presenter. I will add a commit to undo that. But would be good as next step to make the UI behaving to the intended use case.

1. After loading screen -> check if there is an existing user profile.
   1a. If there is an existing user profile, do not show create user profile screen, but show user profile is some not yet defined way (right top corner in Desktop shows user profile).
   1b. If there is no existing user profile, show create profile screen.

Additionally: Show busy animation when generating keypair and when creating the profile. The domain model contains 2 boolean inProgress properties for that.

[HenrikJannsen]

Regarding the Ktor addition. I was working on this as well but in a separate new networking module in an effort to avoid making the androidModule grasp those dependencies when its not gonna be used.

Ah that is good. But maybe we call it 'client' instead of networking, as networking happens also in the node when all is delegated to the libraries.
Is it basically the code from shared.domain.client.
We should also move the Bisq2 replicated models (annotated with @serializable) which are only used for client over there.

Btw. I did not clean up the gradle dependencies, there might be too many and they should be moved to toml file.... also there are those issues with the exclusion of the logging lib... But I guess you have better ideas when it comes to gradle stuff..

[rodvar]

@HenrikJannsen awesome work, this looks so much better.

I'll update the architecture doc to show that presenters can depend on services as well for domain interaction.

I've taken the liberty of doing a small contribution to address the small important stuff that was missing from the my previous review - please have a look at it to see if we agree on it.

Finally, I added some nits, most of it optional or to be done in a subsequent PR. I would say the most important one is the one referred to the HttpClient (Ktor) as using it as is adds boilerplate that can be avoided if configured properly (making it serialize/deserialize automatically)

Let me know your thoughts, I can see this being merge by the end of today :D !

[rodvar]

❤️

[rodvar]

🎉