Feature/multiplatform settings persistence #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rodvar
commented
Nov 26, 2024
•
rodvar
commented
- Implementation of Shared Repositories: Multiplatform Settings #39
- key value store common implementation based on most used KMP lib
- provided common tests with mocked implementation
- using SettingsRepository for an example of real usage: url and connected flag gets saved now and loaded every time the app starts (xClients)
- tested on the 3 apps, using keychain for iOS
bisqapps/shared/domain/src/commonMain/kotlin/network/bisq/mobile/domain/data/model/Settings.kt
Show resolved
Hide resolved
.../domain/src/commonMain/kotlin/network/bisq/mobile/domain/data/persistance/KeyValueStorage.kt
Outdated
Show resolved
Hide resolved
rodvar
force-pushed
the
feature/multiplatform_settings_persistance
branch
from
6de999b to
19cdeaf
Compare
|
rebased to latest main changes |
- added mp lib for settings - configuration for both platforms - implementation of proposed persistanceSource interface - adaptation of base model for serialzation - adaption on Settings model used as example for testing - common tests to proof working as expected
construction and uses data from a protype of the involved T - repositories that doesn't use persistance don't need to provide prototype
rodvar
force-pushed
the
feature/multiplatform_settings_persistance
branch
from
ac1d1fd to
aa4a715
Compare
|
rebased branch to latest main changes |
…e package (Kotlin limitation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.