Add offerbook and marketprice domain #78
Conversation
There was a problem hiding this comment.
tested in 3 apps, it works great (had an issue in iOS not related to this code, see matrix for details)
Besides my code review comments, I've also got a fleet warning with the .png assets.
there is an historic android reason why this happens, images filenames should always be lowercase and if using a separator it should be "_" as opposed to the one used in this PR "-" -> please change the file names to comply with compose assets rules.
That's it for now! I think we could probably merge this later today 💪
...mmonMain/kotlin/network/bisq/mobile/client/offerbook/offer/ClientOfferbookListItemService.kt
Outdated
Show resolved
Hide resolved
...main/src/commonMain/kotlin/network/bisq/mobile/client/offerbook/offer/OfferbookApiGateway.kt
Show resolved
Hide resolved
...ps/shared/domain/src/commonMain/kotlin/network/bisq/mobile/domain/offerbook/OfferListItem.kt
Outdated
Show resolved
Hide resolved
...d/domain/src/commonMain/kotlin/network/bisq/mobile/domain/offerbook/market/MarketListItem.kt
Outdated
Show resolved
Hide resolved
.../domain/src/commonMain/kotlin/network/bisq/mobile/domain/offerbook/market/OfferbookMarket.kt
Outdated
Show resolved
Hide resolved
.../shared/presentation/src/commonMain/kotlin/network/bisq/mobile/presentation/BasePresenter.kt
Outdated
Show resolved
Hide resolved
...n/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/components/atoms/DynamicImage.kt
Outdated
Show resolved
Hide resolved
...src/commonMain/kotlin/network/bisq/mobile/presentation/ui/uicases/startup/SplashPresenter.kt
Outdated
Show resolved
Hide resolved
Add cancelJob method with exception handling
|
Review comments applied beside 2 items (see discussion) |
| super.initializeServices() | ||
| private var applicationServiceCreated = false | ||
| override fun onViewAttached() { | ||
| if (!applicationServiceCreated) { |
There was a problem hiding this comment.
Getting an error here when doing ./gradlew build.
This function needs to call super.onViewAttached()
Same for onViewUnattaching and onDestroying()
There was a problem hiding this comment.
yep I've fixed that before merge buddha! 💪
No description provided.