Add support for cathash image creation in android client #88
Conversation
HenrikJannsen
force-pushed
the
add-support-for-cathash-image-creation-in-android-client
branch
from
3bb16a3 to
2ceb8d3
Compare
|
Continue working on ios.... got the loading of the images resolved. Still having problems to display it... |
HenrikJannsen
force-pushed
the
add-support-for-cathash-image-creation-in-android-client
branch
from
1c315bd to
e207890
Compare
|
henrik still working on this one, marking as draft |
Add scaling
…e need the application base directory. Pass context to AndroidApplicationService. Fix package names. Add image to generateKeyPair as type Any. This is just preliminary due KMP issues with BitMap or related image formats.
- Implemented service dependant on ImageUtils for android node - provided unit tests using Roboelectric emulated instrumentation
Add KMP compatible cathash implementation for clients. This is java code ported from Bisq 2. Move ImageUtil to shared
Add PlatformPainter
Move platform abstractions to one file per module
HenrikJannsen
force-pushed
the
add-support-for-cathash-image-creation-in-android-client
branch
from
dcf03d6 to
f9e8aba
Compare
- provide serialziation helpers for it - fix usage of actual for android, and usage of ImageBitmap for the expected PlatformImage
…er saved profile. Added same code for iOS though not tested yet
rodvar
force-pushed
the
add-support-for-cathash-image-creation-in-android-client
branch
from
9dbab3a to
ff1aace
Compare
|
@HenrikJannsen Haven't been able to work this properly in the It works like charm on androidNode, I've did all the changes considering android and iOS and fix some issues and compilation along the way so later today when I get back to the I'll let you know, I can smell the merge coming soon... please have a look at my changes if you are around 💪 |
...ommonMain/kotlin/network/bisq/mobile/presentation/ui/components/molecules/TopBarPresenter.kt
Show resolved
Hide resolved
|
Ah great that you could get it working on iOS!!! And added support for the top bar! |
HenrikJannsen
deleted the
add-support-for-cathash-image-creation-in-android-client
branch
Based on #86
We have to build the cathash image on the client as otherwise the loading of the images would take too long. We cache the images once created so they are only generated once.
Beside that to provide the image from the Rest API in headless mode would have been quite a hack (I got it working but did not like it - required to start JavaFX in headless mode via the monocle test framework which supports that).
I tried to add iOS support but did not get the images displayed. Beside that the iOS code is ChatGPT derived and must be reviewed/improved/fixed by a dev familiar with iOS.