Code

V5 trade protocol#7105

Code

Draft

stejbac wants to merge 58 commits intobisq-network:masterbisq-network/bisq:masterfrom stejbac:v5-trade-protocolstejbac/bisq:v5-trade-protocolCopy head branch name to clipboard

+7,878-886

Commits

Commits on Oct 10, 2024

• Implement WarningTransactionFactory

  Show description for 2427f91
  

  alvasw

  authored and

  stejbac

  committed
  2427f91

• Implement RedirectionTransactionFactory

  Show description for bd5379b
  

  alvasw

  authored and

  stejbac

  committed
  bd5379b

• Implement ClaimTransactionFactory

  Show description for 71d5f4a
  

  alvasw

  authored and

  stejbac

  committed
  71d5f4a

• Refactoring: Rename BuyerProtocol to BaseBuyerProtocol and SellerProtocol to BaseSellerProtocol

  Show description for bce41a3
  

  HenrikJannsen

  authored and

  stejbac

  committed
  bce41a3

• Refactoring: Add BuyerProtocol and SellerProtocol interfaces

  Show description for b6f9cd8
  

  HenrikJannsen

  authored and

  stejbac

  committed
  b6f9cd8

• Refactoring: Use BuyerProtocol interfaces instead of BaseBuyerProtocol at client code

  Show description for 1b33d25
  

  HenrikJannsen

  authored and

  stejbac

  committed
  1b33d25

• Refactoring: Use SellerProtocol interfaces instead of BaseSellerProtocol at client code

  Show description for 15d29c4
  

  HenrikJannsen

  authored and

  stejbac

  committed
  15d29c4

• Refactoring: Make BaseBuyerProtocol and BaseSellerProtocol package private and constructor protected

  Show description for 8896f01
  

  HenrikJannsen

  authored and

  stejbac

  committed
  8896f01

• Refactoring: Move protocol interfaces one level up

  Show description for 2abf282
  

  HenrikJannsen

  authored and

  stejbac

  committed
  2abf282

• Refactoring: Remove comments

  Show description for 01bcc6e
  

  HenrikJannsen

  authored and

  stejbac

  committed
  01bcc6e

• Refactoring: Add methods to implementation classes even they have not custom code but only call super to make it more transparent which handler methods are in the protocol.

  Show description for 25e2937
  

  HenrikJannsen

  authored and

  stejbac

  committed
  25e2937

• Refactoring: Use getTradeProtocolVersion getter instead of public TRADE_PROTOCOL_VERSION field.

  Show description for 6314619
  

  HenrikJannsen

  authored and

  stejbac

  committed
  6314619

• Refactoring: Rename Protocol classes with _v4 postfix and move to protocol_v4 package

  

  HenrikJannsen

  authored and

  stejbac

  committed
  06d91be

• Use new protocol version after activation date

  Show description for e5eec52
  

  HenrikJannsen

  authored and

  stejbac

  committed
  e5eec52

• Add copies of protocol classes to bisq_v5 package. Those will serve as base for later implementing the new protocol.

  Show description for 3c87ea5
  

  HenrikJannsen

  authored and

  stejbac

  committed
  3c87ea5

• Use new protocol classes if version 5 is activated

  Show description for 2ec3098
  

  HenrikJannsen

  authored and

  stejbac

  committed
  2ec3098

• Add new address entries

  Show description for c11c687
  

  HenrikJannsen

  authored and

  stejbac

  committed
  c11c687

• Set v5 activation date in past for dev testing

  Show description for 6593b2e
  

  HenrikJannsen

  authored and

  stejbac

  committed
  6593b2e

• Change method signatures

  Show description for 6ffffc7
  

  HenrikJannsen

  authored and

  stejbac

  committed
  6ffffc7

• Add util method for calculating fee rate which was used for the deposit tx.

  Show description for 8fd95b7
  

  HenrikJannsen

  authored and

  stejbac

  committed
  8fd95b7

• Add StagedPayoutTxParameters class which holds relevant protocol parameters

  Show description for a37c16d
  

  HenrikJannsen

  authored and

  stejbac

  committed
  a37c16d

• Add fields for new protocol.

  Show description for 2800749
  

  HenrikJannsen

  authored and

  stejbac

  committed
  2800749

• Add InputsForDepositTxResponse_v5 message

  Show description for 299c05f
  

  HenrikJannsen

  authored and

  stejbac

  committed
  299c05f

• Add new tasks for BuyerAsMakerProtocol_v5. We might generalize later to BuyerProtocol_v5, but for now we start with one variant (BuyerAsMakerProtocol_v5 and SellerAsTakerProtocol_v5)

  Show description for 0f88863
  

  HenrikJannsen

  authored and

  stejbac

  committed
  0f88863

• Add new fields

  Show description for d4f7bff
  

  HenrikJannsen

  authored and

  stejbac

  committed
  d4f7bff

• Add InputsForDepositTxResponse_v5 message

  Show description for e4f0ed9
  

  HenrikJannsen

  authored and

  stejbac

  committed
  e4f0ed9

• Add tasks for second phase

  Show description for 408d420
  

  HenrikJannsen

  authored and

  stejbac

  committed
  408d420

• Add BuyersRedirectSellerSignatureRequest

  Show description for e1e19fc
  

  HenrikJannsen

  authored and

  stejbac

  committed
  e1e19fc

• Add tasks for 3rd phase at buyer

  Show description for 08b1640
  

  HenrikJannsen

  authored and

  stejbac

  committed
  08b1640

• Add BuyersRedirectSellerSignatureResponse

  Show description for b0ce2d5
  

  HenrikJannsen

  authored and

  stejbac

  committed
  b0ce2d5

• Add tasks for 4th phase at seller

  Show description for 228e49e
  

  HenrikJannsen

  authored and

  stejbac

  committed
  228e49e

• Comment out correctlySpends checks at claim and redirect txs.

  Show description for f07a923
  

  HenrikJannsen

  authored and

  stejbac

  committed
  f07a923

• Temp changes

  stejbac

  committed
  282f81e

• More temp changes

  stejbac

  committed
  668a7f8

• Fix the warning, redirect & claim txs

  stejbac

  committed
  acd711a

• More changes the get the trade start working

  Show description for a95d4cf
  stejbac

  committed
  a95d4cf

• Fix warning/redirect/claim tx fee calculations

  Show description for b168100
  stejbac

  committed
  b168100

• Make further improvements to the redirect tx fee precision

  Show description for 99b69f2
  stejbac

  committed
  99b69f2

• Provide missing persistence for warning/redirect/claim txs

  Show description for 4291dea
  stejbac

  committed
  4291dea

• Fix UI+log errors/warnings in happy path of v5 trade protocol

  Show description for 888b258
  stejbac

  committed
  888b258

• Add some missing @nullable annotations

  Show description for fcbd833
  stejbac

  committed
  fcbd833

• Ensure v5 staged txs are linked to trade in Transactions view

  Show description for 4753c58
  stejbac

  committed
  4753c58

• Use watched scripts to pick up broadcast of staged txs

  Show description for 3e6b4cf
  stejbac

  committed
  3e6b4cf

• Make Transactions view display correct types & amounts for staged txs

  Show description for dc5284a
  stejbac

  committed
  dc5284a

• Use LowRSigningKey for warning, redirect & claim txs

  Show description for 89af696
  stejbac

  committed
  89af696

• Add extra dispute states for v5 protocol

  Show description for 315e7be
  stejbac

  committed
  315e7be

• Add preliminary code to publish warning tx if mediation fails

  Show description for af33eca
  stejbac

  committed
  af33eca

• Add listener to pick up warning tx broadcast

  Show description for 2a6ee91
  stejbac

  committed
  2a6ee91

• Pick up WARNING_SENT* dispute states in TradeStepView

  Show description for 2c73fb0
  stejbac

  committed
  2c73fb0

• Add downstream listeners to SetupWarningTxListener & rename

  Show description for bdaa03b
  stejbac

  committed
  bdaa03b

• Make Transactions view tolerate missing tx witness data

  Show description for 1ffc914
  stejbac

  committed
  1ffc914

• Add code to redirect or claim after warning tx published

  Show description for ab3502a
  stejbac

  committed
  ab3502a

• Refactor replay detection logic in DisputeValidation

  Show description for 0f626d4
  stejbac

  committed
  0f626d4

• Tidy up DisputeView & fix broken comparator

  Show description for b7330a2
  stejbac

  committed
  b7330a2

• Add warning & redirect txIds to dispute details & filter

  Show description for da05ebf
  stejbac

  committed
  da05ebf

• Adapt refund agent tx chain validation to v5 protocol

  Show description for 360b8a4
  stejbac

  committed
  360b8a4

Commits on Oct 11, 2024

• Sanity check deposit tx output & receiver total before refunding

  Show description for cdc61ea
  stejbac

  committed
  cdc61ea

Commits on Dec 7, 2024

• Restructure redeem script to reduce size of redirect & claim txs

  Show description for f2d3273
  stejbac

  committed
  f2d3273