-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Major update #61
Draft
devinbileck
wants to merge
77
commits into
bisq-network:master
Choose a base branch
from
devinbileck:major-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbileck
force-pushed
the
major-update
branch
2 times, most recently
from
January 31, 2024 07:58
52bb51e
to
bed269a
Compare
devinbileck
force-pushed
the
major-update
branch
2 times, most recently
from
February 1, 2024 21:43
0169d4d
to
1bb66cb
Compare
The latest version of Gradle does not seem to like having duplicate source sets between androidTest and test for a common directory within the same module.
- Refine layout, content, and colors of all UI screens - Implemented an action menu in notification table screen - Reworked settings screen - Implemented dark mode with dark/light mode selection
minSdkVersion was bumped to 26 so as not to worry about handling older versions that may not fully support notifications. This corresponds to Android 8 (released in 2017) and as of now currently covers 94.9% of all Android users (according to apilevels.com/) and over 99% of our install base.
…lsewhere on screen
Using text/plain type should hopefully ensure a copy option is always available in the chooser.
The buildType value was not being set when running the connectedCheck task for instrumentation tests in CI. I did not find a better approach to determining the build type other then checking the task being executed. Therefore, just assume debug in the androidTests reports directory.
Tests for some API levels were failing for not having Google Play services available. Try to use google_apis target for all APIs in CI instrumentation tests.
It seems the restrictions for google_atd system images are no longer applicable.
API 30 emulator is timing out. Related: ReactiveCircus/android-emulator-runner#373
devinbileck
force-pushed
the
major-update
branch
from
February 11, 2024 06:17
440df4b
to
8c7039c
Compare
salam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
UI improvements
Features
Fixes
Outstanding tasks