Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedy startup #649

Merged
merged 7 commits into from
Dec 6, 2024
Merged

Conversation

willcl-ark
Copy link
Contributor

Deploy everything everywhere, all at once (except fork observer).

  • no more waiting for logging to install before we even start the next thing
  • could probably speed up very large networks by multiprocessing individual tank deployment

Fork observer uses k8s api (via get_mission()) to create its config, so it has to wait until at least that deploy is finished.

@pinheadmz
Copy link
Contributor

ooh concept ack nice!

@willcl-ark willcl-ark force-pushed the speedy-startup branch 2 times, most recently from 81e7db6 to 604eb15 Compare October 12, 2024 22:32
@willcl-ark
Copy link
Contributor Author

ping @mplsgrant: I can't understand why the namespace test should fail with these changes (although, I don't totally understand the test that well).

If you get a minute, would appreciate your eyes on it :) (p.s. it still fails even if I drop the commit touching the namespace deploy code...)

@mplsgrant
Copy link
Collaborator

mplsgrant commented Oct 12, 2024

@willcl-ark It looks like it's deploying ingress regardless of whether there is an ingress flag enabled. Our Service Accounts (like bob) can't do deploy ingress. Basically, if you become Bob in the battle of galen, and you try to deploy the armada, then it will complain about not being able to deploy ingress (because of the permissions bob has).

@mplsgrant
Copy link
Collaborator

I should also add that the namespace_admin.py test actually runs the entire scenarios_test.py.

@willcl-ark
Copy link
Contributor Author

willcl-ark commented Oct 16, 2024

TODO:

  • add multiprocessing to scenarios stop all

@bdp-DrahtBot
Copy link
Collaborator

bdp-DrahtBot commented Nov 6, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #670 (Plugin Architecture by mplsgrant)
  • #664 (Restore LN functionality with helm by pinheadmz)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@bdp-DrahtBot bdp-DrahtBot mentioned this pull request Nov 18, 2024
@bdp-DrahtBot bdp-DrahtBot mentioned this pull request Nov 27, 2024
@willcl-ark willcl-ark marked this pull request as ready for review December 5, 2024 16:58
@willcl-ark
Copy link
Contributor Author

undrafted to see if that will make CI work...

Copy link
Contributor

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK, its fast! tytyty

@pinheadmz pinheadmz merged commit 82306a8 into bitcoin-dev-project:main Dec 6, 2024
11 checks passed
@willcl-ark willcl-ark deleted the speedy-startup branch December 6, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants