Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image build: use cmake #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pinheadmz
Copy link
Contributor

Closes #672

Seems to be working for me so far locally, will test a few other options as well.

Should we add a test to CI for this? It might just take too long to run...

@willcl-ark
Copy link
Contributor

We do need this, but it will break rebuilding <= v28.0 images...

I think we should simply add a new dockerfile with this in. When combined with #669 having multiple dockerfiles becomes easy to handle IMO. To build v28.0 you'd just run:

docker buildx bake bitcoin-28

and for >28.0 you'd do:

docker buildx bake bitcoin-29
# or perhaps we can get working...?
docker buildx bake <commit sha>

and let the bake magic handle which dockerfile is used for you.

@pinheadmz
Copy link
Contributor Author

Ah brilliant mate. Will review baker first then rebase this. 👨‍🍳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warnet image build still builds with autotools
2 participants