-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SPV-1160): new record outline endpoint with actual repository for op_return txs #777
base: main
Are you sure you want to change the base?
Conversation
Manual Tests💚 Manual testing by @dorzepowski resulted in success. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
==========================================
+ Coverage 44.88% 45.16% +0.28%
==========================================
Files 350 358 +8
Lines 17217 17360 +143
==========================================
+ Hits 7727 7841 +114
- Misses 8922 8949 +27
- Partials 568 570 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
# Conflicts: # engine/testabilities/fixture_engine.go
return | ||
} | ||
|
||
c.JSON(200, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor
this will return null
as body. Instead you can simple use
c.Status(200)
This pull request introduces several new functionalities and improvements to the SPV Wallet project, particularly focusing on transaction recording and testing capabilities. The key changes include the addition of new services, interfaces, and test fixtures to support transaction recording and handling.
Transaction Recording Enhancements:
New Service for Recording Transactions:
engine/transaction/record
package. [1] [2] [3]transactionRecordOutline
function inactions/transactions/outlines_record.go
to handle recording transaction outlines.Database Integration:
Transaction
,Output
,Data
) for handling transaction data. [1] [2] [3]Testing Improvements:
New Test Fixtures:
ARCFixture
interface and implementation to support testing of ARC-related functionalities. [1] [2]SPVWalletApplicationFixture
to include the newARC
method.New Test Cases:
actions/transactions/outlines_record_test.go
.Code Refactoring:
Refactored Import Statements:
Service Initialization:
These enhancements significantly improve the functionality and testability of the SPV Wallet project, especially in terms of handling and recording transaction data.
Pull Request Checklist