[bitnami/milvus] PDB review (#25983)

* [bitnami/milvus] PDB review Signed-off-by: Fran Mulero <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> * Amend pdb.maxUnavailable and pdb.minAvailable types Signed-off-by: Fran Mulero <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Increase ETCD resources for testing Signed-off-by: Fran Mulero <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Set verification=SERIAL. Current infrastructure can spin up 2 charts at the same time Signed-off-by: Fran Mulero <[email protected]> --------- Signed-off-by: Fran Mulero <[email protected]> Signed-off-by: Carlos Rodríguez Hernández <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Bitnami Containers <[email protected]>
bitnami · May 30, 2024 · 4e80463 · 4e80463
1 parent 149d1a0
commit 4e80463
Show file tree

Hide file tree

Showing 15 changed files with 1,163 additions and 823 deletions.
diff --git a/.vib/milvus/vib-action.config b/.vib/milvus/vib-action.config
@@ -0,0 +1,2 @@
+verification-mode=SERIAL
+
diff --git a/bitnami/milvus/CHANGELOG.md b/bitnami/milvus/CHANGELOG.md
@@ -1,8 +1,12 @@
 # Changelog
 
+## 8.1.0 (2024-05-29)
+
+* [bitnami/milvus] PDB review ([#25983](https://github.com/bitnami/charts/pull/25983))
+
 ## 8.0.0 (2024-05-27)
 
-* [bitnami/milvus] Update dependencies ([#26445](https://github.com/bitnami/charts/pull/26445))
+* [bitnami/milvus] Update dependencies (#26445) ([e4dc085](https://github.com/bitnami/charts/commit/e4dc085dc62abade1fb18389831ad5a4ef41a75d)), closes [#26445](https://github.com/bitnami/charts/issues/26445)
 
 ## <small>7.1.2 (2024-05-24)</small>
 

diff --git a/bitnami/milvus/Chart.yaml b/bitnami/milvus/Chart.yaml
@@ -48,4 +48,4 @@ maintainers:
 name: milvus
 sources:
 - https://github.com/bitnami/charts/tree/main/bitnami/milvus
-version: 8.0.0
+version: 8.1.0
diff --git a/bitnami/milvus/README.md b/bitnami/milvus/README.md
diff --git a/bitnami/milvus/templates/attu/pdb.yaml b/bitnami/milvus/templates/attu/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.attu.pdb.create }}
+{{- if and .Values.attu.enabled .Values.attu.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -21,8 +21,8 @@ spec:
   {{- if .Values.attu.pdb.minAvailable }}
   minAvailable: {{ .Values.attu.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.attu.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.attu.pdb.maxUnavailable }}
+  {{- if or .Values.attu.pdb.maxUnavailable (not .Values.attu.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.attu.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.attu.podLabels .Values.commonLabels ) "context" . ) }}
   selector:

diff --git a/bitnami/milvus/templates/data-coordinator/pdb.yaml b/bitnami/milvus/templates/data-coordinator/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.dataCoord.pdb.create }}
+{{- if and .Values.dataCoord.enabled .Values.dataCoord.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -19,8 +19,8 @@ spec:
   {{- if .Values.dataCoord.pdb.minAvailable }}
   minAvailable: {{ .Values.dataCoord.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.dataCoord.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.dataCoord.pdb.maxUnavailable }}
+  {{- if or .Values.dataCoord.pdb.maxUnavailable (not .Values.dataCoord.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.dataCoord.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.dataCoord.podLabels .Values.commonLabels ) "context" . ) }}
   selector:

diff --git a/bitnami/milvus/templates/data-node/pdb.yaml b/bitnami/milvus/templates/data-node/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.dataNode.pdb.create }}
+{{- if and .Values.dataNode.enabled .Values.dataNode.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -19,8 +19,8 @@ spec:
   {{- if .Values.dataNode.pdb.minAvailable }}
   minAvailable: {{ .Values.dataNode.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.dataNode.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.dataNode.pdb.maxUnavailable }}
+  {{- if or .Values.dataNode.pdb.maxUnavailable (not .Values.dataNode.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.dataNode.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.dataNode.podLabels .Values.commonLabels ) "context" . ) }}
   selector:

diff --git a/bitnami/milvus/templates/index-coordinator/pdb.yaml b/bitnami/milvus/templates/index-coordinator/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.indexCoord.pdb.create }}
+{{- if and .Values.indexCoord.enabled .Values.indexCoord.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -19,8 +19,8 @@ spec:
   {{- if .Values.indexCoord.pdb.minAvailable }}
   minAvailable: {{ .Values.indexCoord.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.indexCoord.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.indexCoord.pdb.maxUnavailable }}
+  {{- if or .Values.indexCoord.pdb.maxUnavailable (not .Values.indexCoord.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.indexCoord.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.indexCoord.podLabels .Values.commonLabels ) "context" . ) }}
   selector:

diff --git a/bitnami/milvus/templates/index-node/pdb.yaml b/bitnami/milvus/templates/index-node/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.indexNode.pdb.create }}
+{{- if and .Values.indexNode.enabled .Values.indexNode.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -19,8 +19,8 @@ spec:
   {{- if .Values.indexNode.pdb.minAvailable }}
   minAvailable: {{ .Values.indexNode.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.indexNode.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.indexNode.pdb.maxUnavailable }}
+  {{- if or .Values.indexNode.pdb.maxUnavailable (not .Values.indexNode.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.indexNode.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.indexNode.podLabels .Values.commonLabels ) "context" . ) }}
   selector:

diff --git a/bitnami/milvus/templates/proxy/pdb.yaml b/bitnami/milvus/templates/proxy/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.proxy.pdb.create }}
+{{- if and .Values.proxy.enabled .Values.proxy.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -19,8 +19,8 @@ spec:
   {{- if .Values.proxy.pdb.minAvailable }}
   minAvailable: {{ .Values.proxy.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.proxy.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.proxy.pdb.maxUnavailable }}
+  {{- if or .Values.proxy.pdb.maxUnavailable (not .Values.proxy.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.proxy.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.proxy.podLabels .Values.commonLabels ) "context" . ) }}
   selector:

diff --git a/bitnami/milvus/templates/query-coordinator/pdb.yaml b/bitnami/milvus/templates/query-coordinator/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.queryCoord.pdb.create }}
+{{- if and .Values.queryCoord.enabled .Values.queryCoord.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -19,8 +19,8 @@ spec:
   {{- if .Values.queryCoord.pdb.minAvailable }}
   minAvailable: {{ .Values.queryCoord.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.queryCoord.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.queryCoord.pdb.maxUnavailable }}
+  {{- if or .Values.queryCoord.pdb.maxUnavailable (not .Values.queryCoord.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.queryCoord.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.queryCoord.podLabels .Values.commonLabels ) "context" . ) }}
   selector:

diff --git a/bitnami/milvus/templates/query-node/pdb.yaml b/bitnami/milvus/templates/query-node/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.queryNode.pdb.create }}
+{{- if and .Values.queryNode.enabled .Values.queryNode.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -19,8 +19,8 @@ spec:
   {{- if .Values.queryNode.pdb.minAvailable }}
   minAvailable: {{ .Values.queryNode.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.queryNode.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.queryNode.pdb.maxUnavailable }}
+  {{- if or .Values.queryNode.pdb.maxUnavailable (not .Values.queryNode.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.queryNode.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.queryNode.podLabels .Values.commonLabels ) "context" . ) }}
   selector:

diff --git a/bitnami/milvus/templates/root-coordinator/pdb.yaml b/bitnami/milvus/templates/root-coordinator/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.rootCoord.pdb.create }}
+{{- if and .Values.rootCoord.enabled .Values.rootCoord.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -19,8 +19,8 @@ spec:
   {{- if .Values.rootCoord.pdb.minAvailable }}
   minAvailable: {{ .Values.rootCoord.pdb.minAvailable }}
   {{- end }}
-  {{- if .Values.rootCoord.pdb.maxUnavailable }}
-  maxUnavailable: {{ .Values.rootCoord.pdb.maxUnavailable }}
+  {{- if or .Values.rootCoord.pdb.maxUnavailable (not .Values.rootCoord.pdb.minAvailable) }}
+  maxUnavailable: {{ .Values.rootCoord.pdb.maxUnavailable | default 1 }}
   {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.rootCoord.podLabels .Values.commonLabels ) "context" . ) }}
   selector: