[bitnami/metrics-server] PDB review (#25982)

Signed-off-by: Fran Mulero <[email protected]> Signed-off-by: Andrés Bono <[email protected]> Co-authored-by: Andrés Bono <[email protected]>
bitnami · May 20, 2024 · 68e5a56 · 68e5a56
1 parent b2bb25e
commit 68e5a56
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/bitnami/metrics-server/Chart.yaml b/bitnami/metrics-server/Chart.yaml
@@ -28,4 +28,4 @@ maintainers:
 name: metrics-server
 sources:
 - https://github.com/bitnami/charts/tree/main/bitnami/metrics-server
-version: 7.0.6
+version: 7.1.0
diff --git a/bitnami/metrics-server/README.md b/bitnami/metrics-server/README.md
@@ -134,7 +134,7 @@ As an alternative, you can use one of the preset configurations for pod affinity
 | `terminationGracePeriodSeconds`                     | In seconds, time the given to the metrics-server pod needs to terminate gracefully                                                                                                                                | `""`                             |
 | `podAffinityPreset`                                 | Pod affinity preset. Ignored if `affinity` is set. Allowed values: `soft` or `hard`                                                                                                                               | `""`                             |
 | `podAntiAffinityPreset`                             | Pod anti-affinity preset. Ignored if `affinity` is set. Allowed values: `soft` or `hard`                                                                                                                          | `soft`                           |
-| `pdb.create`                                        | Create a PodDisruptionBudget                                                                                                                                                                                      | `false`                          |
+| `pdb.create`                                        | Create a PodDisruptionBudget                                                                                                                                                                                      | `true`                           |
 | `pdb.minAvailable`                                  | Minimum available instances                                                                                                                                                                                       | `""`                             |
 | `pdb.maxUnavailable`                                | Maximum unavailable instances                                                                                                                                                                                     | `""`                             |
 | `nodeAffinityPreset.type`                           | Node affinity preset type. Ignored if `affinity` is set. Allowed values: `soft` or `hard`                                                                                                                         | `""`                             |

diff --git a/bitnami/metrics-server/templates/pdb.yaml b/bitnami/metrics-server/templates/pdb.yaml
@@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
 SPDX-License-Identifier: APACHE-2.0
 */}}
 
-{{- if .Values.pdb.create -}}
+{{- if .Values.pdb.create }}
 apiVersion: {{ include "common.capabilities.policy.apiVersion" . }}
 kind: PodDisruptionBudget
 metadata:
@@ -16,11 +16,11 @@ metadata:
 spec:
   {{- if .Values.pdb.minAvailable }}
   minAvailable: {{ .Values.pdb.minAvailable }}
-  {{- end  }}
+  {{- end }}
   {{- if .Values.pdb.maxUnavailable }}
   maxUnavailable: {{ .Values.pdb.maxUnavailable }}
-  {{- end  }}
+  {{- end }}
   {{- $podLabels := include "common.tplvalues.merge" ( dict "values" ( list .Values.podLabels .Values.commonLabels ) "context" . ) }}
   selector:
     matchLabels: {{- include "common.labels.matchLabels" ( dict "customLabels" $podLabels "context" $ ) | nindent 6 }}
-{{- end -}}
+{{- end }}
diff --git a/bitnami/metrics-server/values.yaml b/bitnami/metrics-server/values.yaml
@@ -248,7 +248,7 @@ podAntiAffinityPreset: soft
 ## @param pdb.maxUnavailable Maximum unavailable instances
 ##
 pdb:
-  create: false
+  create: true
   minAvailable: ""
   maxUnavailable: ""
 ## Node affinity preset