Skip to content

Commit

Permalink
add default pihole.password value
Browse files Browse the repository at this point in the history
When not using pihole, the lack of a pihole.password setting would cause the template to fail since it expects the key to exist.

Signed-off-by: James Harr <[email protected]>
  • Loading branch information
jamesharr committed Jun 13, 2024
1 parent c550d7d commit 757cbcb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bitnami/external-dns/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ maintainers:
name: external-dns
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/external-dns
version: 7.5.5
version: 7.5.6
3 changes: 2 additions & 1 deletion bitnami/external-dns/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ helm install my-release \
| `ns1.secretName` | Use an existing secret with key "ns1-api-key" defined. | `""` |
| `pihole.server` | When using the Pi-hole provider, specify The address of the Pi-hole web server | `""` |
| `pihole.tlsSkipVerify` | When using the Pi-hole provider, specify wheter to skip verification of any TLS certificates served by the Pi-hole web server | `""` |
| `pihole.password` | When using the Pi-hole provider, specify a password to use | `""` |
| `pihole.secretName` | Use an existing secret with key "pihole_password" defined. | `""` |
| `oci.region` | When using the OCI provider, specify the region, where your zone is located in. | `""` |
| `oci.tenancyOCID` | When using the OCI provider, specify your Tenancy OCID | `""` |
Expand Down Expand Up @@ -557,4 +558,4 @@ Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
3 changes: 3 additions & 0 deletions bitnami/external-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,9 @@ pihole:
## @param pihole.tlsSkipVerify When using the Pi-hole provider, specify wheter to skip verification of any TLS certificates served by the Pi-hole web server
##
tlsSkipVerify: ""
## @param pihole.password When using the Pi-hole provider, specify a password to use
##
password: ""
## @param pihole.secretName Use an existing secret with key "pihole_password" defined.
##
secretName: ""
Expand Down

0 comments on commit 757cbcb

Please sign in to comment.