Skip to content

Commit

Permalink
[bitnami/milvus] Fix milvus externalS3 config, address minor typos
Browse files Browse the repository at this point in the history
Signed-off-by: rajan123456 <[email protected]>
  • Loading branch information
rajan123456 committed Jun 13, 2024
1 parent 8cf02f2 commit a389fa9
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion bitnami/milvus/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ maintainers:
name: milvus
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/milvus
version: 8.2.2
version: 8.2.3
4 changes: 2 additions & 2 deletions bitnami/milvus/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,12 @@ externalEtcd:

### External S3 support

You may want to have mastodon connect to an external storage streaming rather than installing MiniIO(TM) inside your cluster. To achieve this, the chart allows you to specify credentials for an external storage streaming with the [`externalS3` parameter](#parameters). You should also disable the MinIO(TM) installation with the `minio.enabled` option. Here is an example:
You may want to have Milvus connect to an external storage streaming rather than installing MiniIO(TM) inside your cluster. To achieve this, the chart allows you to specify credentials for an external storage streaming with the [`externalS3` parameter](#parameters). You should also disable the MinIO(TM) installation with the `minio.enabled` option. Here is an example:

```console
minio.enabled=false
externalS3.host=myexternalhost
exterernalS3.accessKeyID=accesskey
externalS3.accessKeyID=accesskey
externalS3.accessKeySecret=secret
```

Expand Down
2 changes: 1 addition & 1 deletion bitnami/milvus/templates/externals3-secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Copyright Broadcom, Inc. All Rights Reserved.
SPDX-License-Identifier: APACHE-2.0
*/}}

{{- if and (not .Values.minio.enabled) (not .Values.externalS3.existingSecret) .Values.enableS3 }}
{{- if and (not .Values.minio.enabled) (not .Values.externalS3.existingSecret) .Values.externalS3 }}
apiVersion: v1
kind: Secret
metadata:
Expand Down
2 changes: 1 addition & 1 deletion bitnami/milvus/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5262,7 +5262,7 @@ externalEtcd:
##
keyPassword: ""
## @section External S3 parameters
## All of these values are only used when redis.enabled is set to false
## All of these values are only used when minio.enabled is set to false
## @param externalS3.host External S3 host
## @param externalS3.port External S3 port number
## @param externalS3.accessKeyID External S3 access key ID
Expand Down

0 comments on commit a389fa9

Please sign in to comment.