-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/apisix] JSONSchema too strict for extraEnvVars #27319
Comments
Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here. Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance. |
Sure thing. I can put a PR together for this. |
PR opened! |
Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close. Your contribution is greatly appreciated! |
Hello @carrodher . Sorry to bug you about this, but do you have a timeline for when the PR might be reviewed by? I'm more than happy to reduce the changes if that will help with the review. I'm just hoping to not have to continue forking the chart for too long to get around a simple JSON schema validation issue. |
Hi @james-mchugh, thank you for your contribution! We truly appreciate your effort and interest in improving the bitnami/apisix chart. Our team currently has a high volume of Issues and Pull Requests to review. Please be assured that we are doing our best to get to yours as soon as possible. We appreciate your patience and understanding. |
Name and Version
bitnami/apisix:3.1.2
What architecture are you using?
amd64
What steps will reproduce the bug?
.Values.dataPlane.extraEnvVars
to a string (containing Helm templating, for example)helm template .
Are you using any custom parameters or values?
What is the expected behavior?
dataPlane.extraEnvVars
allows for strings as the value is passed to thecommon.tplvalues.render
template function prior to being added to the deployment/daemonset.What do you see instead?
Additional information
There may be additional fields with similar issues.
I took a look at the Bitnami Postgresql chart, which omits
extraEnvVars
fields from the JSON schema. Other charts may handle this differently though.The text was updated successfully, but these errors were encountered: