-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql] Allow loadBalancerClass to be customized #25569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaime Martínez Rincón <[email protected]>
Signed-off-by: Jaime Martínez Rincón <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Jaime Martínez Rincón <[email protected]>
carrodher
added
verify
Execute verification workflow for these changes
in-progress
labels
May 7, 2024
Signed-off-by: Andrés Bono <[email protected]>
Signed-off-by: Andrés Bono <[email protected]>
andresbono
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you so much for your contribution
clarifai-fmarceau
pushed a commit
to clarifai-fmarceau/bitnami-charts
that referenced
this pull request
May 30, 2024
…mi#25569) * feat: add loadBalancerClass field Signed-off-by: Jaime Martínez Rincón <[email protected]> * chore: bump version Signed-off-by: Jaime Martínez Rincón <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Jaime Martínez Rincón <[email protected]> * Update Chart.yaml Signed-off-by: Andrés Bono <[email protected]> --------- Signed-off-by: Jaime Martínez Rincón <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Andrés Bono <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Andrés Bono <[email protected]> Signed-off-by: Francois Marceau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR allows the
loadBalancerClass
to be customized via the chart values in thepostgresql
chart.Benefits
Allows the following values to be set, setting the
loadBalancerClass
to be set in the respectiveService
primary.service.loadBalancerClass
readReplicas.service.loadBalancerClass
Possible drawbacks
None
Applicable issues
None
Additional information
N/A
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm