[bitnami/external-dns] Add aws.zoneMatchParent option #25575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrodher
added
verify
dgomezleon
reviewed
May 7, 2024
bitnami/external-dns/Chart.yaml
Outdated
| @@ -28,4 +28,4 @@ maintainers: | |||
| name: external-dns | |||
| sources: | |||
| - https://github.com/bitnami/charts/tree/main/bitnami/external-dns | |||
| version: 7.2.1 | |||
| version: 7.2.2 | |||
There was a problem hiding this comment.
Please bump the minor version to add new values.
Suggested change
| version: 7.2.2 | |
| version: 7.3.0 |
Signed-off-by: Clemens Gruber <[email protected]>
clemensg
force-pushed
the
external_dns_aws_zone_match_parent
branch
from
9681e79 to
75c211c
Compare
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: David Gomez <[email protected]>
dgomezleon
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add support for the aws.zoneMatchParent option (defaulting to false) and add corresponding documentation.
Benefits
Users can set aws.zoneMatchParent to true and set a domain filter for subdomains, e.g. a.b.example.com. This was not possible before with external-dns and Route53.
See kubernetes-sigs/external-dns#4236
Possible drawbacks
None
Applicable issues
None
Additional information
N/A
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm