[bitnami/thanos] Receive, ruler & storegateway statefulsets persistentVolumeClaimRetentionPolicy support

[clarifai-fmarceau]

Description of the change

These changes add persistentVolumeClaimRetentionPolicy support to statefulsets of the Thanos Helm chart.

Benefits

We can now set persistentVolumeClaimRetentionPolicy.whenScaled & persistentVolumeClaimRetentionPolicy.whenDeleted for Ruler, Receive & Store Gateway individually.

Possible drawbacks

None, the change is feature flagged and if enabled the defaults are aligned with the Kubernetes ones.

Applicable issues

• fixes [bitnami/thanos] Statefulsets persistentVolumeClaimRetentionPolicy support #25339

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[carrodher]

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

[clarifai-fmarceau]

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Just signed an empty commit in my fork's branch, is that enough !? I'm sorry about that, I thought that having my commits signed on Github directly was it/ was enough.

[carrodher]

It seems it's not enough since the DCO action is still failing. Here you can see the details and how to fix the issue.

[clarifai-fmarceau]

Thank you for pointing me to that! Done, signed off every commit.

[juan131]

Thanks for this great contribution! Please ensure you merge latest changes from main branch and resolve the conflicts.

Also, please note the PersistentVolumeClaim retention was included in Kubernetes 1.23 and therefore, we should include take it into account introducing the safeguard below:

{{- if semverCompare ">=1.23-0" (include "common.capabilities.kubeVersion" .) -}}

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[juan131]

@clarifai-fmarceau did you see my last comment?

[clarifai-fmarceau]

@clarifai-fmarceau did you see my last comment?

Fixed ! Hopefully we can now merge this !

On a side note, support for persistentVolumeClaimRetentionPolicy is already in a few of your charts and there's no safeguard around it. I didn't push back based on that because it's a fair comment/ change request but just wanted to point that out.

[juan131]

LGMT! Thanks so much for the contribution