Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql-ha] add backup.cronjob.tolerations options #25683

Merged
merged 9 commits into from
May 20, 2024

Conversation

colin719
Copy link
Contributor

Description of the change

add .Values.backup.cronjob.tolerations for posgresql-ha

Benefits

add tolerations for backup job

Possible drawbacks

none

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/postgresql-ha] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added postgresql-ha triage Triage is needed labels May 11, 2024
@github-actions github-actions bot requested a review from carrodher May 11, 2024 09:18
@colin719 colin719 force-pushed the add-pg-ha-backup-tolerations branch from 563a4f8 to 2dde559 Compare May 11, 2024 09:50
@colin719 colin719 force-pushed the add-pg-ha-backup-tolerations branch from 2dde559 to f166b8c Compare May 11, 2024 09:51
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 13, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 13, 2024
@github-actions github-actions bot removed the request for review from carrodher May 13, 2024 06:50
@github-actions github-actions bot requested a review from rafariossaa May 13, 2024 06:50
@colin719
Copy link
Contributor Author

waiting so long time

rafariossaa
rafariossaa previously approved these changes May 16, 2024
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for adding this.

@rafariossaa rafariossaa merged commit 6ce2aa9 into bitnami:main May 20, 2024
10 checks passed
fmulero pushed a commit to fmulero/charts that referenced this pull request May 22, 2024
…mi#25683)

* [bitnami/postgresql-ha] add backup.cronjob.tolerations options

Signed-off-by: Colin Lee <[email protected]>

* Update README.md with readme-generator-for-helm

Signed-off-by: Bitnami Containers <[email protected]>

* [bitnami/postgresql-ha] add backup.cronjob.tolerations options

Signed-off-by: Colin Lee <[email protected]>

* Update README.md with readme-generator-for-helm

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Colin Lee <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Signed-off-by: Fran Mulero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postgresql-ha solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants