Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/gitea] Add new customizable environment variables - ENABLE OPENID SIGNIN/SIGNUP #25684

Merged
merged 6 commits into from
May 14, 2024
Merged

Conversation

ikamii
Copy link
Contributor

@ikamii ikamii commented May 11, 2024

[bitnami/gitea] Add new customizable environment variables

1. ENABLE_OPENID_SIGNIN (default: false)
2. ENABLE_OPENID_SIGNUP (default: false)

Description of the change

All changes have made after approval of the PR.

Changes have made in:

  • values.yaml (added 2 new parameters openid.enableSignIn, openid.enableSignUp)
  • templates/deployment.yaml (To set the custom environment variables.)
  • README.md
  • Chart.yaml (Chart version)

Benefits

Possible drawbacks

Users can enable OpenID sign in and OpenID sign up if necessary. ( I might use it for signing in via Keycloak for example.)

Applicable issues

Additional information

Checklist

  • [ x ] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [ x ] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [ x ] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • [ x ] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

ikamii added 2 commits May 11, 2024 11:28
                1. ENABLE_OPENID_SIGNIN (default: false)
		2. ENABLE_OPENID_SIGNUP (default: false)

Signed-off-by: Ismail Kutlay Acar <[email protected]>
@github-actions github-actions bot added the gitea label May 11, 2024
@github-actions github-actions bot added the triage Triage is needed label May 11, 2024
@github-actions github-actions bot requested a review from javsalgar May 11, 2024 10:03
@ikamii
Copy link
Contributor Author

ikamii commented May 11, 2024

I am unfortunately not sure if I did the Chart versioning correctly. If not please tell me to change it thanks!

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 13, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 13, 2024
@github-actions github-actions bot removed the request for review from javsalgar May 13, 2024 06:56
@github-actions github-actions bot requested a review from alemorcuq May 13, 2024 06:56
@alemorcuq
Copy link
Contributor

Thanks! Since you did some changes to the container, we need to wait for a new container to be released and then change the image in the chart to the new one.

@ikamii
Copy link
Contributor Author

ikamii commented May 13, 2024

Thanks! Since you did some changes to the container, we need to wait for a new container to be released and then change the image in the chart to the new one.

Sure! Do you maybe know how long does it take for a new container to be released?

Should I change the image in the chart then or would someone in the team do it?

Thanks!

@ikamii
Copy link
Contributor Author

ikamii commented May 14, 2024

Hi @alemorcuq

I have seen that the gitea image has been updated on Docker Hub so I have updated the values.yaml as expected.

Thanks again!

@alemorcuq alemorcuq merged commit 9cca25b into bitnami:main May 14, 2024
9 checks passed
@ikamii ikamii deleted the gitea-ikamii branch May 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gitea solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants