-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/gitea] Add new customizable environment variables - ENABLE OPENID SIGNIN/SIGNUP #25684
Conversation
1. ENABLE_OPENID_SIGNIN (default: false) 2. ENABLE_OPENID_SIGNUP (default: false) Signed-off-by: Ismail Kutlay Acar <[email protected]>
Signed-off-by: Ismail Kutlay Acar <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
I am unfortunately not sure if I did the Chart versioning correctly. If not please tell me to change it thanks! |
Thanks! Since you did some changes to the container, we need to wait for a new container to be released and then change the image in the chart to the new one. |
Sure! Do you maybe know how long does it take for a new container to be released? Should I change the image in the chart then or would someone in the team do it? Thanks! |
Signed-off-by: Ismail Kutlay Acar <[email protected]>
Hi @alemorcuq I have seen that the gitea image has been updated on Docker Hub so I have updated the values.yaml as expected. Thanks again! |
Signed-off-by: Alejandro Moreno <[email protected]>
[bitnami/gitea] Add new customizable environment variables
Description of the change
All changes have made after approval of the PR.
Changes have made in:
values.yaml
(added 2 new parametersopenid.enableSignIn
,openid.enableSignUp
)Benefits
Possible drawbacks
Users can enable
OpenID sign in
andOpenID sign up
if necessary. ( I might use it for signing in via Keycloak for example.)Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm