Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/haproxy] Add enableServiceLinks (#25851) #25852

Merged
merged 1 commit into from
May 17, 2024
Merged

[bitnami/haproxy] Add enableServiceLinks (#25851) #25852

merged 1 commit into from
May 17, 2024

Conversation

olivierboudet
Copy link
Contributor

Description of the change

Allow to set enableServiceLinks on haproxy, true by default.

Benefits

Some users need to set enableServiceLinks=false

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added haproxy triage Triage is needed labels May 14, 2024
@github-actions github-actions bot requested a review from javsalgar May 14, 2024 11:52
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 14, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 14, 2024
@github-actions github-actions bot removed the request for review from javsalgar May 14, 2024 14:04
@github-actions github-actions bot requested a review from migruiz4 May 14, 2024 14:04
migruiz4
migruiz4 approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, looks good to me!

@migruiz4 migruiz4 merged commit e239577 into bitnami:main May 17, 2024
25 checks passed
fmulero pushed a commit to fmulero/charts that referenced this pull request May 22, 2024
@olivierboudet @fmulero
[bitnami/haproxy] Add enableServiceLinks (bitnami#25851) (bitnami#25852)
9315e1d 
Signed-off-by: Olivier Boudet <[email protected]>
Signed-off-by: Fran Mulero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migruiz4 migruiz4 migruiz4 approved these changes

Assignees

@migruiz4 migruiz4

Labels
haproxy solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/haproxy] allow to set enableServiceLinks
4 participants
@olivierboudet @migruiz4 @javsalgar @carrodher