Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/concourse] PDB review #25869

Merged
merged 5 commits into from
May 20, 2024
Merged

Conversation

fmulero
Copy link
Collaborator

@fmulero fmulero commented May 14, 2024

Description of the change

Little fixes in PodDisruptionBudget configuration to keep it aligned with current templates.

Benefits

Keep our charts up to date according to our templates

Possible drawbacks

None

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label May 14, 2024
@github-actions github-actions bot requested a review from rafariossaa May 14, 2024 15:07
bitnami-bot and others added 3 commits May 14, 2024 15:07
Signed-off-by: Fran Mulero <[email protected]>
Signed-off-by: Fran Mulero <[email protected]>
rafariossaa
rafariossaa previously approved these changes May 16, 2024
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmulero fmulero enabled auto-merge (squash) May 20, 2024 09:35
@fmulero fmulero merged commit d8a78da into bitnami:main May 20, 2024
10 checks passed
fmulero added a commit to fmulero/charts that referenced this pull request May 22, 2024
* [bitnami/concourse] PDB review

Signed-off-by: Fran Mulero <[email protected]>

* Update README.md with readme-generator-for-helm

Signed-off-by: Bitnami Containers <[email protected]>

* Fix bad references

Signed-off-by: Fran Mulero <[email protected]>

* Fix pdb conditions

Signed-off-by: Fran Mulero <[email protected]>

---------

Signed-off-by: Fran Mulero <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Signed-off-by: Fran Mulero <[email protected]>
@fmulero fmulero added the pdb label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami concourse pdb solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants