[bitnami/grafana-loki] Network policy review #25904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the same changes made in PR bitnami#25519 to the Loki chart Signed-off-by: Ben Foster <[email protected]>
bpfoster
force-pushed
the
loki-networkpolicy
branch
from
653908f to
f8648f4
Compare
carrodher
added
verify
juan131
approved these changes
May 16, 2024
juan131
requested changes
May 16, 2024
| {{- range $key, $value := .Values.compactor.networkPolicy.ingressNSMatchLabels }} | ||
| {{ $key | quote }}: {{ $value | quote }} | ||
| {{- end }} | ||
| matchLabels: {{- include "common.tplvalues.render" (dict "value" $ingressNSMatchLabels "context" $ ) | nindent 14 }} |
There was a problem hiding this comment.
This $ingressNSMatchLabels variable hasn't been defined.
There was a problem hiding this comment.
Oops - too much blind copy-paste, sorry. Great catch. Fixed!
Signed-off-by: Ben Foster <[email protected]>
bpfoster
force-pushed
the
loki-networkpolicy
branch
from
ded6ed9 to
f69e394
Compare
fmulero
pushed a commit
to fmulero/charts
that referenced
this pull request
May 22, 2024
Signed-off-by: Fran Mulero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Apply the same changes made in PR #25519 to the Loki chart
Review network policy features to allow users cover their needs without forcing specific labels.
Benefits
Users can restrict access to their deployments in a cleaner way, without leaving open doors to specific labeled pods.
Possible drawbacks
None
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm