-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/milvus] feat: config external kafka tls client certs setting… #26118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @chenraoCR! I have updated the comments at milvus.prepareMilvusInitContainer
to use capital letters.
Additionally, I would like to request one change in this PR.
Instead of {{- if (not (empty .Values.*)) }}
could you please use {{- if .Values.* }}
? That would simplify the conditionals and help improve code readability.
ddb37e4
to
76021be
Compare
noted, and already updated |
2432948
to
43af221
Compare
@migruiz4 i committed the PR for quite some time and updated the requested changes, could u please merge it? |
Hi @chenraoCR, I'm sorry for the inconvenience. We were having an issue with the CI/CD pipeline for Milvus and the tests were not passing due to a problem unrelated to this PR. Because the CI/CD pipeline would not succeed we couldn't merge this PR. |
cf653e3
to
b1a9753
Compare
bitnami#26110) Signed-off-by: Chen Rao <[email protected]>
277f148
to
cb5dd86
Compare
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@migruiz4 now seems okay, plz check and merge, thanks |
Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Description of the change
config externalKafka tls settings
Benefits
allow users to config kafka tls client certs when connect external kafka running with tls
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm