Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/rabbitmq] Pass service.extraPorts to the headless service #26136

Merged
merged 3 commits into from
May 27, 2024
Merged

[bitnami/rabbitmq] Pass service.extraPorts to the headless service #26136

merged 3 commits into from
May 27, 2024

Conversation

aqeelat
Copy link
Contributor

@aqeelat aqeelat commented May 20, 2024

Description of the change

The chart allowed users to add additional ports to the service. However, these ports were not being passed to the headless service. I just fixed that.

Benefits

The headless service now mirrors the ports of the service.

Possible drawbacks

None comes to mind.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added rabbitmq triage Triage is needed labels May 20, 2024
@github-actions github-actions bot requested a review from javsalgar May 20, 2024 16:54
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 20, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 20, 2024
@github-actions github-actions bot removed the request for review from javsalgar May 20, 2024 22:37
@github-actions github-actions bot requested a review from rafariossaa May 20, 2024 22:37
rafariossaa
rafariossaa previously approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.
LGTM

@rafariossaa rafariossaa enabled auto-merge (squash) May 24, 2024 14:00
@bitnami-bot
Update CHANGELOG.md
1853225 
Signed-off-by: Bitnami Containers <[email protected]>
@aqeelat
Copy link
Contributor Author

aqeelat commented May 25, 2024

@rafariossaa happy to help. What is left for the PR to be merged?

rafariossaa
rafariossaa approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafariossaa rafariossaa merged commit 346eddf into bitnami:main May 27, 2024
7 checks passed
@migruiz4 migruiz4 mentioned this pull request Jul 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafariossaa rafariossaa rafariossaa approved these changes

Assignees

@rafariossaa rafariossaa

Labels
rabbitmq solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/rabbitmq] extraPorts are not being passed to the headless service
5 participants
@aqeelat @rafariossaa @javsalgar @carrodher @bitnami-bot