[bitnami/kafka] #25646 Kafka config with yaml parameter map

[rubenvw-ngdata]

Description of the change

Use a yaml parameter map instead of a flat file for the extraConfig parameter. This allows for easier overloading both between the default and broker / controller values; and between multiple values.yaml.

Benefits

You can now overload config values easily.

Applicable issues

• fixes [bitnami/kafka] add support for helm parameter maps for extraConfig #25646

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[migruiz4]

Hi @rubenvw-ngdata,

Thank you for your contribution!

As mentioned in my comments, I would appreciate it if you could consider adding this feature as a new value instead of introducing a non-backward compatible change.

[rubenvw-ngdata]

@migruiz4 Still a bit in doubt whether supporting both is better and if there is any advantage using the 'old' extraConfig at all.
In most strings, the quotes will not be required, so that is not a valid reason for me.

Please go ahead and review and merge this if you agree with the changes as you proposed them.

if I convinced you of dropping the old extraConfig property, and I will make the changes for that.

[migruiz4]

Thank you very much for applying my suggestions!

I see the tpl I suggested was causing some issues. I tested your branch locally and using common.tplvalues.render should fix the issue.

[migruiz4]

Regarding your comment, the reason to keep both extraConfig and extraConfigYaml is mostly to not introduce a non-backward compatible change, and therefore force a new major.

Additionally, with the plaintext extraConfig you could technically use templates at a higher level, for example:

extraConfig: |
   {{- $iterator := list "a" "b" "c" }}
   {{- range $i := $iterator }}
   kafka.setting.$i=false
   {{-end}}
   {{- if .Values.metrics.enabled }}
   ...
   {{- else }}
   ...
   {{- end }}

Can not ensure anyone is using the value extraConfig at that level, but by replacing it we would be removing this feature and forcing users to perform manual action to migrate to the new YAML object format.

[migruiz4]

Thank you very much for your contribution!