Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/kube-prometheus] Add imagePullPolicy to Prometheus and Alertmanager #26553

Merged
merged 5 commits into from
Jun 1, 2024
Merged

[bitnami/kube-prometheus] Add imagePullPolicy to Prometheus and Alertmanager #26553

merged 5 commits into from
Jun 1, 2024

Conversation

gespinozat
Copy link
Contributor

Description of the change

Adds imagePullPolicy to Prometheus and Alertmanager

Benefits

Enables setting imagePullPolicy for Prometheus and Alertmanager instances

Possible drawbacks

None noted

Applicable issues

None

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added kube-prometheus triage Triage is needed labels May 29, 2024
@github-actions github-actions bot requested a review from carrodher May 29, 2024 19:10
@bitnami-bot
Update CHANGELOG.md
b601cc5 
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 30, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 30, 2024
@github-actions github-actions bot removed the request for review from carrodher May 30, 2024 09:51
@github-actions github-actions bot requested a review from dgomezleon May 30, 2024 09:51
@bitnami-bot
Update CHANGELOG.md
82597b5 
Signed-off-by: Bitnami Containers <[email protected]>
dgomezleon
dgomezleon reviewed May 31, 2024
View reviewed changes
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. The change LGTM. Could you please bump a minor instead of a patch version since new values have been added?

gespinozat and others added 2 commits May 31, 2024 09:51
@gespinozat
Bump minor version
03092f3 
Signed-off-by: German Espinoza <[email protected]>
@bitnami-bot
Update CHANGELOG.md
6dc5978 
Signed-off-by: Bitnami Containers <[email protected]>
@dgomezleon dgomezleon enabled auto-merge (squash) June 1, 2024 00:29
@dgomezleon dgomezleon merged commit ed64806 into bitnami:main Jun 1, 2024
8 checks passed
@fmulero fmulero mentioned this pull request Jun 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgomezleon dgomezleon dgomezleon approved these changes

Assignees

@dgomezleon dgomezleon

Labels
kube-prometheus solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gespinozat @dgomezleon @carrodher @bitnami-bot