[bitnami/vault] fix injector #26611
Merged
[bitnami/vault] fix injector #26611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiří Matěják <[email protected]>
Signed-off-by: Jiří Matěják <[email protected]>
Signed-off-by: Jiří Matěják <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Fran Mulero <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Hi @SpeedGriffon Thanks a lot for your contribution and for taking care of this issue.
I left a little comment. Could you take it glance?
| @@ -105,7 +105,7 @@ spec: | |||
| - name: AGENT_INJECT_LISTEN | |||
| value: :{{ .Values.injector.containerPorts.https }} | |||
| - name: AGENT_INJECT_VAULT_ADDR | |||
| value: http://{{ include "vault.server.fullname" . }}:{{ .Values.server.service.general.ports.http }} | |||
| value: http://{{ include "vault.server.fullname" . }}.{{ include "common.names.namespace" . }}.svc:{{ .Values.server.service.general.ports.http }} | |||
There was a problem hiding this comment.
Why don't use the FQDN?
Suggested change
| value: http://{{ include "vault.server.fullname" . }}.{{ include "common.names.namespace" . }}.svc:{{ .Values.server.service.general.ports.http }} | |
| value: http://{{ include "vault.server.fullname" . }}.{{ include "common.names.namespace" . }}.svc.{{ .Values.clusterDomain }}:{{ .Values.server.service.general.ports.http }} |
There was a problem hiding this comment.
I went with what they use in the official chart.
Also, this way it's consistent with AGENT_INJECT_TLS_AUTO_HOSTS and it works with the default values.yaml even if the cluster domain is not cluster.local.
There was a problem hiding this comment.
Thanks a lot @SpeedGriffon. LGTM
Signed-off-by: Jiří Matěják <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
approved these changes
Jun 10, 2024
| @@ -105,7 +105,7 @@ spec: | |||
| - name: AGENT_INJECT_LISTEN | |||
| value: :{{ .Values.injector.containerPorts.https }} | |||
| - name: AGENT_INJECT_VAULT_ADDR | |||
| value: http://{{ include "vault.server.fullname" . }}:{{ .Values.server.service.general.ports.http }} | |||
| value: http://{{ include "vault.server.fullname" . }}.{{ include "common.names.namespace" . }}.svc:{{ .Values.server.service.general.ports.http }} | |||
There was a problem hiding this comment.
Thanks a lot @SpeedGriffon. LGTM
longnbao
pushed a commit
to longnbao/bitnami-helm-charts
that referenced
this pull request
Jun 12, 2024
* [bitnami/vault] fix injector networkpolicy ingress port Signed-off-by: Jiří Matěják <[email protected]> * [bitnami/vault] fix AGENT_INJECT_VAULT_ADDR Signed-off-by: Jiří Matěják <[email protected]> * [bitnami/vault] bump chart version Signed-off-by: Jiří Matěják <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Jiří Matěják <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Carlos Rodríguez Hernández <[email protected]> Signed-off-by: Fran Mulero <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Long Bao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes the Vault Injector Deployment and NetworkPolicy.
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm