-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New chart: Chainloop #27100
New chart: Chainloop #27100
Conversation
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Hi! Thank you so much for the PR! Could you fix the action errors? Specially the license headers, as we cannot accept a contribution unless the copyright headers match the requirements. |
Signed-off-by: Javier Rodriguez <[email protected]>
Thanks Salme for the quick reply :) We have just question regarding the license header changes. We have indeed added them but probably with the wrong scope.
What entitles the change on the header? That you folks take ownership and control on Chart from the moment is merged? |
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Hello Salme, Regarding the license headers, no worries on the question, we have updated it to be compliant, so I think we are good on that side! :D Additionally I wanted to highlight something I wrote on the description:
Our take is that for the moment we could embed the Dex manifests in the chart to the make it work if it's ok! |
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Miguel <[email protected]>
Signed-off-by: Miguel <[email protected]>
Signed-off-by: Miguel <[email protected]>
Hi team, I've made some changes which include
|
We will replace upstream dex for a variation of the templates found here. @javsalgar let me know if you'd prefer if we follow some other approach. To us, we just need an OIDC provider, it doesn't need to be dex, so happy for recommendations if you have any other in the catalog. Thanks |
Hi @javirln @migmartri, Thank you very much for your contribution! I have noticed that most of the files in this PR haven't been created using the template chart as base, and therefore missing many features that are common between all the charts in our catalog. Some examples:
I would appreciate it if you could adapt those manifests and include the missing values. Additionally, I have noticed the gce-proxy image is hardcoded and does not allow users to set it in the I'm currently working on releasing all the required images as part of the Bitnami catalog, including the gce-proxy image. I will let you know once they are available so we can update the chart to use them. |
bitnami/chainloop/Chart.yaml
Outdated
version: 1.4.x | ||
description: Chainloop is an open source software supply chain control plane, a single source of truth for artifacts plus a declarative attestation crafting process. | ||
home: https://bitnami.com | ||
icon: https://bitnami.com/assets/stacks/chainloop-control-plane/img/chainloop-control-plane-stack-220x234.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon: https://bitnami.com/assets/stacks/chainloop-control-plane/img/chainloop-control-plane-stack-220x234.png | |
icon: https://bitnami.com/assets/stacks/chainloop/img/chainloop-stack-220x234.png |
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Javier Rodriguez <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for implementing the feedback!
Some additional comments, in this case they are mostly minor details
Signed-off-by: Javier Rodriguez <[email protected]>
@migruiz4 everything addressed, thanks again for the review :D |
Ditto, thanks @migruiz4 for the detailed review :)
…On Thu, Aug 8, 2024, 6:08 PM Javier Rodríguez ***@***.***> wrote:
@migruiz4 <https://github.com/migruiz4> everything addressed, thanks
again for the review :D
—
Reply to this email directly, view it on GitHub
<#27100 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF7S5C6YRHHYARJHAJTLLZQOJXFAVCNFSM6AAAAABJEQZIS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWGE4DMMZVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @javirln @migmartri, thank you very much!
Thanks a lot, @migruiz4, for the thorough review; you helped us a lot to improve our chart 🥇 Re: the image used in the chart and Bitnami listing, could you use this logo instead? or this one? Thanks a lot! |
Hi! You mean without the bitnami hexagon? |
hi @javsalgar, this looks ok, but it would be great, if possible, to try this version, which removed most of the padding around the logo. Thanks for checking on this @javsalgar, you guys rock :) |
Could you remove the black border? It's doing something strange with the logo |
hi @javsalgar, sorry I didn't understand the request, what black border? |
Description of the change
This PR adds a new chart to the catalog: Chainloop, an open-source software supply chain control plane, the evidence store and a single source of truth for artifacts, metadata plus a declarative attestation crafting process.
This solution is compounded by 4 different components:
We included support for the following K8s objects for every component:
A more in depth explanation and guides to the Chainloop chart can be found here.
Additional information
The Helm Chart can be deployed in two different modes,
standard
anddevelopment
.If
development
is active, a Vault Chart will be installed along with the rest of services for secret management.While the default deployment mode,
standard
relies on external dependencies to be available in advance.Important notice
The current implementation of the Chainloop Chart requires a Dex instance configured as an OIDC provider. We found an external Dex chart not provided by Bitnami and considered using it but we were wondering if you would consider to package it as part of your catalog?. Additionally, we noticed that Bitnami's Argo-CD includes Dex templates within its chart. Could this be an option for us as well?
Additionally we keep working on adding more integration tests to the Chart.
How do we build the images?
The images are built using a GoReleaser action that takes as source of truth a
Dockerfile
. Here the links:All those images are then pushed to GHCR: https://github.com/orgs/chainloop-dev/packages?repo_name=chainloop
All of them based on
scratch
Checklist