Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/thanos] add terminationGracePeriod receiveDistributor #28570

Conversation

alecrajeev
Copy link
Contributor

Description of the change

There is an option for a terminationGracePeriod for a thanos-receive distributor deployment.

Benefits

This allows for more highly available restarts of the thanos-receive distributor deployment.

Possible drawbacks

Applicable issues

  • Fixes an issue where when you update the receiveDistributor image, there are some errors returned.

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added thanos triage Triage is needed labels Jul 29, 2024
@github-actions github-actions bot requested a review from javsalgar July 29, 2024 21:08
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jul 31, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jul 31, 2024
@github-actions github-actions bot removed the request for review from javsalgar July 31, 2024 10:07
@github-actions github-actions bot requested a review from andresbono July 31, 2024 10:07
@alecrajeev alecrajeev force-pushed the arajeev/update-thanos-receive-distributor-termination-grace-period branch 2 times, most recently from 8de67f8 to 31270e7 Compare August 2, 2024 13:30
@alecrajeev alecrajeev force-pushed the arajeev/update-thanos-receive-distributor-termination-grace-period branch from 2ddf82a to 52441f9 Compare August 8, 2024 19:48
Signed-off-by: Bitnami Containers <[email protected]>
@alecrajeev alecrajeev force-pushed the arajeev/update-thanos-receive-distributor-termination-grace-period branch from 15b509d to a8d1695 Compare August 8, 2024 19:49
@alecrajeev alecrajeev closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved thanos verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants