Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/fluentd] update README.md #28797

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[bitnami/fluentd] update README.md #28797

merged 1 commit into from
Aug 9, 2024

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Aug 9, 2024

Description of the change

update READMD.md, becase extraEnv are renamed to extraEnvVars,so update docs.

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added fluentd triage Triage is needed labels Aug 9, 2024
@github-actions github-actions bot requested a review from javsalgar August 9, 2024 05:43
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Aug 9, 2024
@github-actions github-actions bot removed the triage Triage is needed label Aug 9, 2024
@github-actions github-actions bot removed the request for review from javsalgar August 9, 2024 06:51
@github-actions github-actions bot requested a review from dgomezleon August 9, 2024 06:51
dgomezleon
dgomezleon approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@dgomezleon dgomezleon merged commit 82058a3 into bitnami:main Aug 9, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgomezleon dgomezleon dgomezleon approved these changes

Assignees

@dgomezleon dgomezleon

Labels
fluentd solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lixd @dgomezleon @javsalgar