Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/rabbitmq-cluster-operator] Add AdmissionWebhookConfig toggle #28801

Merged
merged 6 commits into from
Aug 23, 2024
Merged

[bitnami/rabbitmq-cluster-operator] Add AdmissionWebhookConfig toggle #28801

merged 6 commits into from
Aug 23, 2024

Conversation

silveiralexf
Copy link
Contributor

@silveiralexf silveiralexf commented Aug 9, 2024

Description of the change

This PR proposes a new toggle to allow users to skip creation of AdmissionWebhookConfig resource.

Benefits

This toggle can be useful for when users have restricted cluster-wide permissions and are only allowed to deploy namespaced scope resources.

Possible drawbacks

The only drawback is the fact that users would have to manually create the AdmissionWebhookConfig by themselves.

Applicable issues

  • N/A

Additional information

Since the default value for the toggle is set to false we would keep compatibility with the current behaviour, without risking a breaking change for users that are unaware or don't require the use of this toggle -- only users who explicitly opt-in would make use of it.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Aug 10, 2024
@github-actions github-actions bot removed the triage Triage is needed label Aug 10, 2024
@github-actions github-actions bot removed the request for review from javsalgar August 10, 2024 06:22
@github-actions github-actions bot requested a review from fmulero August 10, 2024 06:22
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @silveiralexf for your contribution.

LGTM

@fmulero fmulero merged commit 8513e0e into bitnami:main Aug 23, 2024
11 checks passed
@silveiralexf silveiralexf deleted the feat-msgTopologyOperator-WebhookCfg branch August 26, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rabbitmq-cluster-operator solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants