Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/nats] metrics exporter probe configuration #28825

Merged
merged 7 commits into from
Aug 13, 2024
Merged

[bitnami/nats] metrics exporter probe configuration #28825

merged 7 commits into from
Aug 13, 2024

Conversation

koval-v
Copy link
Contributor

@koval-v koval-v commented Aug 11, 2024

Description of the change

Added the ability to configure livenessProbe and readinessProbe for metrics exporter container

Benefits

This feature gives us possibility configure livenessProbe and readinessProbe when reason of restarting is container with metrics exporter

Possible drawbacks

None

Additional information

Probe

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added nats triage Triage is needed labels Aug 11, 2024
@github-actions github-actions bot requested a review from carrodher August 11, 2024 17:51
@bitnami-bot
Update CHANGELOG.md
73c61c1 
Signed-off-by: Bitnami Containers <[email protected]>
@bitnami-bot
Update README.md with readme-generator-for-helm
c61bdd0 
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Aug 12, 2024
@github-actions github-actions bot removed the triage Triage is needed label Aug 12, 2024
@github-actions github-actions bot removed the request for review from carrodher August 12, 2024 09:08
@github-actions github-actions bot requested a review from dgomezleon August 12, 2024 09:09
@bitnami-bot
Update CHANGELOG.md
f223ab4 
Signed-off-by: Bitnami Containers <[email protected]>
dgomezleon
dgomezleon reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

bitnami/nats/Chart.yaml Outdated Show resolved Hide resolved
koval-v and others added 2 commits August 12, 2024 19:54
@koval-v @dgomezleon
[bitnami/nats] Update bitnami/nats/Chart.yaml
baab032 
Co-authored-by: David Gomez <[email protected]>
Signed-off-by: Viktor <[email protected]>
@bitnami-bot
Update CHANGELOG.md
7d2aece 
Signed-off-by: Bitnami Containers <[email protected]>
dgomezleon
dgomezleon approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgomezleon dgomezleon merged commit 4c8a589 into bitnami:main Aug 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgomezleon dgomezleon dgomezleon approved these changes

Assignees

@dgomezleon dgomezleon

Labels
nats solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koval-v @dgomezleon @javsalgar @carrodher @bitnami-bot