Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/grafana-operator] Add some pod scheduling directives #28861

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

dazoakley
Copy link
Contributor

Description of the change

This adds the ability to set some pod scheduling primitives on the created grafana instance (if required):

  • topologySpreadConstraints on the created grafana deployment/pods
  • A PodDisruptionBudget resource targeted at the created grafana instance to add resiliency

Benefits

This will allow users to improve the scheduling of their pods (i.e. across AZs) and also ensure resiliency in node recycling events.

Possible drawbacks

This assumes users are not setting a component label on their operator deployment. This would be an easy change for any consumer though (to remove/update their label)

Applicable issues

n/a

Additional information

n/a

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@dazoakley dazoakley force-pushed the grafana-pod-scheduling branch from 00c2190 to 45d4ae9 Compare August 13, 2024 15:14
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Aug 14, 2024
@github-actions github-actions bot removed the triage Triage is needed label Aug 14, 2024
@github-actions github-actions bot removed the request for review from javsalgar August 14, 2024 07:18
@github-actions github-actions bot requested a review from andresbono August 14, 2024 07:18
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Contributor

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!! 🎉

@andresbono andresbono merged commit 6cf09be into bitnami:main Aug 20, 2024
11 checks passed
@dazoakley dazoakley deleted the grafana-pod-scheduling branch August 28, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grafana-operator solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants