Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/apisix] dataPlane add hostPort #28900

Closed
wants to merge 2 commits into from

Conversation

chenliang
Copy link

@chenliang chenliang commented Aug 16, 2024

Description of the change

Adds new options dataPlane.hostPort.enabled (default is false) support using host port

Benefits

Allows direct use of ports 80 and 443 of the node

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added apisix triage Triage is needed labels Aug 16, 2024
@github-actions github-actions bot requested a review from javsalgar August 16, 2024 09:00
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@chenliang chenliang force-pushed the feature/hostPort branch 4 times, most recently from 5e42877 to a5c8abf Compare August 19, 2024 02:12
Signed-off-by: Bitnami Containers <[email protected]>
Copy link

github-actions bot commented Sep 4, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Sep 4, 2024
Copy link

github-actions bot commented Sep 9, 2024

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label Sep 9, 2024
@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Sep 9, 2024
@bitnami-bot bitnami-bot closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apisix solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants