[bitnami/mlflow] Add support for Google Cloud Storage as artifact store #28938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Mauti <[email protected]>
Signed-off-by: Nicolas Mauti <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
|
Thank you @mautini for this contribution! The CI failed for some reason. Let me retry it and I will review the PR. Thanks! |
andresbono
reviewed
Sep 4, 2024
| @@ -273,6 +288,11 @@ spec: | |||
| {{- if .Values.tracking.persistence.subPath }} | |||
| subPath: {{ .Values.tracking.persistence.subPath }} | |||
| {{- end }} | |||
| {{- if and (include "mlflow.v0.gcs.enabled" .) .Values.externalGCS.useCredentialsInSecret .Values.externalGCS.existingSecret }} | |||
| - name: google-application-credentials | |||
There was a problem hiding this comment.
There is no volume called like that, should it be gcs-key? Or the other way around.
There was a problem hiding this comment.
You're right. I took this part from the original MR there: #26461 as I don't use this authentication method. Let's rename it to gcs-key
Co-authored-by: Andrés Bono <[email protected]> Signed-off-by: Nicolas Mauti <[email protected]>
Signed-off-by: Nicolas Mauti <[email protected]>
|
Hi @andresbono, thanks a lot for your careful review. I applied your suggested changes, responded to your questions and pushed a fix for the mounting of |
Signed-off-by: Bitnami Containers <[email protected]>
andresbono
reviewed
Sep 5, 2024
Co-authored-by: Andrés Bono <[email protected]> Signed-off-by: Nicolas Mauti <[email protected]>
|
All good for me, thanks! |
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
andresbono
approved these changes
Sep 6, 2024
mike12806
pushed a commit
to mike12806/charts
that referenced
this pull request
Oct 30, 2024
…re (bitnami#28938) * Add support for GCS artifact storage Signed-off-by: Nicolas Mauti <[email protected]> * Generate README from values file Signed-off-by: Nicolas Mauti <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Apply suggestions from code review Co-authored-by: Andrés Bono <[email protected]> Signed-off-by: Nicolas Mauti <[email protected]> * Fix keys.json mounting Signed-off-by: Nicolas Mauti <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Apply suggestions from code review Co-authored-by: Andrés Bono <[email protected]> Signed-off-by: Nicolas Mauti <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Nicolas Mauti <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: Andrés Bono <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR follows this one #26461 and integration of
google-cloud-storagelibrary in bitnami mlflow Docker image: bitnami/containers#67246It adds support to Google Cloud Storage as backend store for mlflow artifacts. The use could specify credentials via workload identity or application credential.
Benefits
User will be able to use Google Storage as backend for artifact storage in mlflow tracking. This is useful for other that migrate from another mlflow instance (running with GCS as backend) or that cannot use other cloud provider.
Possible drawbacks
More complexity to the helm chart / configuration? But it's a feature supported by mlflow so I think we have to expose it.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm