Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mlflow] Update externalS3.host example #28955

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

Jasper-Ben
Copy link
Contributor

@Jasper-Ben Jasper-Ben commented Aug 21, 2024

Description of the change

AWS S3 HTTP endpoints are always regional, with s3.amazonaws.com defaulting to us-east-1. To avoid issues or confusion when using buckets from other regions, we should encourage including region code in the host.

Benefits

Avoid potential issues with buckets in AWS S3 regions other than us-east-1.

Possible drawbacks

None.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added mlflow triage Triage is needed labels Aug 21, 2024
@github-actions github-actions bot requested a review from carrodher August 21, 2024 16:31
AWS S3 HTTP endpoints are always regional, with `s3.amazonaws.com`
defaulting to us-east-1. To avoid issues when using buckets from
other regions, we should encourage including region code in the host.

Fixes: bitnami#23959

Signed-off-by: Jasper Orschulko <[email protected]>
@Jasper-Ben Jasper-Ben force-pushed the update_s3_host_docs branch from ab7aa10 to c5c159f Compare August 21, 2024 16:32
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Aug 22, 2024
@github-actions github-actions bot removed the triage Triage is needed label Aug 22, 2024
@github-actions github-actions bot removed the request for review from carrodher August 22, 2024 07:28
@github-actions github-actions bot requested a review from dgomezleon August 22, 2024 07:28
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@dgomezleon dgomezleon merged commit ce491c1 into bitnami:main Aug 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlflow solved verify Execute verification workflow for these changes
Projects
None yet
5 participants