Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/postgresql-ha] bugfix: conditions to set POSTGRES_POSTGRES_PASSWORD #29120

Merged
merged 5 commits into from
Sep 6, 2024
Merged

[bitnami/postgresql-ha] bugfix: conditions to set POSTGRES_POSTGRES_PASSWORD #29120

merged 5 commits into from
Sep 6, 2024

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Aug 30, 2024

Description of the change

This PR fixes the conditions under we should set the POSTGRES_POSTGRES_PASSWORD (which is only required when the username isn't postgres).

Benefits

PostgreSQL is properly configured when consuming passwords from existing secrets.

Possible drawbacks

None

Applicable issues

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Aug 30, 2024
@github-actions github-actions bot requested a review from fmulero August 30, 2024 06:46
bitnami-bot and others added 4 commits August 30, 2024 06:51
@bitnami-bot
Update CHANGELOG.md
43addc1 
Signed-off-by: Bitnami Containers <[email protected]>
@juan131
bugfix: typo
70b4f55 
Signed-off-by: juan131 <[email protected]>
@fmulero
Merge branch 'main' into bugfix/postgresql-ha-postgres-password
2281686 
Signed-off-by: Fran Mulero <[email protected]>
@bitnami-bot
Update CHANGELOG.md
4f20ea9 
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
fmulero approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan131 juan131 merged commit f24c7f7 into bitnami:main Sep 6, 2024
9 checks passed
@github-actions github-actions bot added the solved label Sep 6, 2024
@juan131 juan131 deleted the bugfix/postgresql-ha-postgres-password branch September 6, 2024 12:01
mike12806 pushed a commit to mike12806/charts that referenced this pull request Oct 30, 2024
@juan131 @mike12806
[bitnami/postgresql-ha] bugfix: conditions to set POSTGRES_POSTGRES_P…
de7a2ce 
…ASSWORD (bitnami#29120)

Signed-off-by: Michael Faherty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero fmulero approved these changes

Assignees

@fmulero fmulero

Labels
bitnami postgresql-ha solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql-ha] Existing secret enforces key "postgres-password" even if user is postgres
3 participants
@juan131 @fmulero @bitnami-bot