-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/memcached] Add optional emptyDir medium configuration #29295
Conversation
Signed-off-by: Niklas Hanft <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. However, I think you also need to apply the change in the templates/statefulset.yaml file.
@jotamartos thx for having a look, I added your suggestions! |
Bump version to 7.5 Signed-off-by: Niklas Hanft <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Niklas <[email protected]>
Signed-off-by: Niklas <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There were merge conflicts due to an automatic update happening in the mean time using my previous used chart version 7.4.15, which I did not know about. I thought it was the bot hallucinating and tried to remove it from the changelog. I now need to to everything all over again |
Description of the change
This change adds the ability to define the emptyDir configuration of memcache to be "Memory"
Benefits
People can decide to configure their tmp directory to be tmpfs (RAM-backed filesystem)
Possible drawbacks
See k8s docs for memory impact on tmpfs volumes: https://kubernetes.io/docs/concepts/storage/volumes/#emptydir
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm