Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/memcached] Add optional emptyDir medium configuration #29295

Closed
wants to merge 8 commits into from
Closed

[bitnami/memcached] Add optional emptyDir medium configuration #29295

wants to merge 8 commits into from

Conversation

nhh
Copy link
Contributor

@nhh nhh commented Sep 7, 2024

Description of the change

This change adds the ability to define the emptyDir configuration of memcache to be "Memory"

Benefits

People can decide to configure their tmp directory to be tmpfs (RAM-backed filesystem)

Possible drawbacks

See k8s docs for memory impact on tmpfs volumes: https://kubernetes.io/docs/concepts/storage/volumes/#emptydir

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added memcached triage Triage is needed labels Sep 7, 2024
@github-actions github-actions bot requested a review from javsalgar September 7, 2024 10:22
@nhh nhh changed the title Draft: bitnami/memcache Add optional emptyDir medium configuration Draft: [bitnami/memcached] Add optional emptyDir medium configuration Sep 7, 2024
@nhh nhh marked this pull request as ready for review September 7, 2024 10:49
Signed-off-by: Bitnami Containers <[email protected]>
@nhh nhh changed the title Draft: [bitnami/memcached] Add optional emptyDir medium configuration [bitnami/memcached] Add optional emptyDir medium configuration Sep 7, 2024
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 7, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 7, 2024
@github-actions github-actions bot removed the request for review from javsalgar September 7, 2024 11:47
@github-actions github-actions bot requested a review from jotamartos September 7, 2024 11:47
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. However, I think you also need to apply the change in the templates/statefulset.yaml file.

bitnami/memcached/Chart.yaml Outdated Show resolved Hide resolved
@nhh
Copy link
Contributor Author

nhh commented Sep 9, 2024

The change looks good to me. However, I think you also need to apply the change in the templates/statefulset.yaml file.

@jotamartos thx for having a look, I added your suggestions!

@nhh nhh closed this Sep 9, 2024
@nhh
Copy link
Contributor Author

nhh commented Sep 9, 2024

There were merge conflicts due to an automatic update happening in the mean time using my previous used chart version 7.4.15, which I did not know about. I thought it was the bot hallucinating and tried to remove it from the changelog.

I now need to to everything all over again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memcached solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants