Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/minio]: Templating sleep sleep time so that it can be passed using values.yaml #30718

Merged
merged 19 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bitnami/minio/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
# Changelog

## 14.10.0 (2024-12-12)

* [bitnami/minio]: Templating sleep sleep time so that it can be passed using values.yaml ([#30718](https://github.com/bitnami/charts/pull/30718))

## 14.9.0 (2024-12-10)

* [bitnami/minio] Detect non-standard images ([#30924](https://github.com/bitnami/charts/pull/30924))
* [bitnami/*] Add Bitnami Premium to NOTES.txt (#30854) ([3dfc003](https://github.com/bitnami/charts/commit/3dfc00376df6631f0ce54b8d440d477f6caa6186)), closes [#30854](https://github.com/bitnami/charts/issues/30854)
* [bitnami/minio] Detect non-standard images (#30924) ([a5d33d4](https://github.com/bitnami/charts/commit/a5d33d4add1c48085781da15b5d349c79b007595)), closes [#30924](https://github.com/bitnami/charts/issues/30924)

## <small>14.8.6 (2024-12-04)</small>

Expand Down
2 changes: 1 addition & 1 deletion bitnami/minio/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ maintainers:
name: minio
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/minio
version: 14.9.0
version: 14.10.0
3 changes: 2 additions & 1 deletion bitnami/minio/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ You can enable this initContainer by setting `volumePermissions.enabled` to `tru
| `statefulset.zones` | Number of zones (only for MinIO&reg; distributed mode) | `1` |
| `statefulset.drivesPerNode` | Number of drives attached to every node (only for MinIO&reg; distributed mode) | `1` |
| `provisioning.enabled` | Enable MinIO&reg; provisioning Job | `false` |
| `provisioning.sleepTime` | Sleep time before checking Minio availability | `5` |
| `provisioning.schedulerName` | Name of the k8s scheduler (other than default) for MinIO&reg; provisioning | `""` |
| `provisioning.nodeSelector` | Node labels for pod assignment. Evaluated as a template. | `{}` |
| `provisioning.podLabels` | Extra labels for provisioning pods | `{}` |
Expand Down Expand Up @@ -661,4 +662,4 @@ Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
2 changes: 1 addition & 1 deletion bitnami/minio/templates/provisioning-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ spec:
# Adding a sleep to ensure that the check below does not cause
# a race condition. We check for the MinIO port because the
# "mc admin service restart --wait" command is not working as expected
sleep 5;
sleep {{ .Values.provisioning.sleepTime | default 5 }};
echo "Waiting for Minio to be available after restart";
wait-for-port \
--host={{ include "common.names.fullname" . }} \
Expand Down
3 changes: 3 additions & 0 deletions bitnami/minio/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,9 @@ provisioning:
## @param provisioning.enabled Enable MinIO&reg; provisioning Job
##
enabled: false
## @param provisioning.sleepTime Sleep time before checking Minio availability
##
sleepTime: 5
dgomezleon marked this conversation as resolved.
Show resolved Hide resolved
## @param provisioning.schedulerName Name of the k8s scheduler (other than default) for MinIO&reg; provisioning
## ref: https://kubernetes.io/docs/tasks/administer-cluster/configure-multiple-schedulers/
##
Expand Down
Loading