[bitnami/thanos] Add concurrency value to compactor #30722
Merged
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a field to set the concurrency of the Thanos Compactor
Benefits
This is a key field that controls resource consumption and processing speed of the compactor. Having this available as a core option instead of needing to set
extraFlags
would be helpful.Possible drawbacks
None that I am aware of. The default value for this field is already 1. Docs link
Applicable issues
I did not create an issue.
Additional information
According to the Thanos Compactor documentation:
and
I am no expert at writing Helm Charts, but the idea crossed my mind of allowing the chart to use the allocated CPU amount to dynamically set the concurrency level of the compactor. This could be especially useful when using
resourcesPreset
. Currently, the compactor won't really speed up at all when going from asmall
to a2xlarge
because it will still be constrained by the default value of this field. I was unable to find examples of this pattern being implemented online successfully, so perhaps it is just an anti-pattern to have dynamic chart behavior in that way.Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm