-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql] Add Storage Class Configuration to Templates #30858
Conversation
Signed-off-by: Søren Schwartz <[email protected]>
Signed-off-by: Søren Schwartz <[email protected]>
Thanks for your contribution! Please note to test the Helm charts it is needed to split the changes of each chart into separate PRs |
Signed-off-by: Søren Schwartz <[email protected]>
Made a second PR |
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @3schwartz for your contribution!
Just a quick suggestion, Could you add this change to read replicas also? the value readReplicas.persistence.storageClass
already exists so the change should be the same for the read replicas statefulset
Signed-off-by: Søren Schwartz <[email protected]>
✅ |
Signed-off-by: Søren Schwartz <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!!. Thanks @3schwartz LGTM
Description of the change
Add configurations to the template.
Benefits
It is possible to define a storage class.
Applicable issues
Currently not able to define the storage class even though the configuration in the
values.yaml
file is there.Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm