Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] Add Storage Class Configuration to Templates #30858

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

3schwartz
Copy link
Contributor

@3schwartz 3schwartz commented Dec 10, 2024

Description of the change

Add configurations to the template.

Benefits

It is possible to define a storage class.

Applicable issues

Currently not able to define the storage class even though the configuration in the values.yaml file is there.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Søren Schwartz <[email protected]>
Signed-off-by: Søren Schwartz <[email protected]>
@github-actions github-actions bot added the triage Triage is needed label Dec 10, 2024
@github-actions github-actions bot requested a review from carrodher December 10, 2024 14:17
@carrodher
Copy link
Member

Thanks for your contribution! Please note to test the Helm charts it is needed to split the changes of each chart into separate PRs

@3schwartz 3schwartz changed the title [bitnami/postgresql-ha][bitnami/postgresql] Add Storage Class Configuration to Templates [bitnami/postgresql] Add Storage Class Configuration to Templates Dec 11, 2024
Signed-off-by: Søren Schwartz <[email protected]>
@3schwartz
Copy link
Contributor Author

Thanks for your contribution! Please note to test the Helm charts it is needed to split the changes of each chart into separate PRs

Made a second PR
#30993

@carrodher carrodher added verify Execute verification workflow for these changes in-progress postgresql labels Dec 11, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 11, 2024
@github-actions github-actions bot removed the request for review from carrodher December 11, 2024 20:24
@github-actions github-actions bot requested a review from fmulero December 11, 2024 20:24
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @3schwartz for your contribution!

Just a quick suggestion, Could you add this change to read replicas also? the value readReplicas.persistence.storageClass already exists so the change should be the same for the read replicas statefulset

Signed-off-by: Søren Schwartz <[email protected]>
@3schwartz
Copy link
Contributor Author

readReplicas.persistence

@3schwartz 3schwartz requested a review from fmulero December 12, 2024 15:29
3schwartz and others added 2 commits December 12, 2024 16:30
Signed-off-by: Søren Schwartz <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!. Thanks @3schwartz LGTM

@fmulero fmulero merged commit b0d2c2e into bitnami:main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postgresql solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants