[bitname/redis] Add support for master and replicas resources to be annotated #31034
+21
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcaracuel
force-pushed
the
feature/add-support-for-master-replicas-annotations
branch
from
67f489e to
c459619
Compare
signed-off-by: gcaracuel <[email protected]>
gcaracuel
force-pushed
the
feature/add-support-for-master-replicas-annotations
branch
from
c459619 to
066e7bc
Compare
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Enables annotation to just resources (StatefulSet) that creates master and replicas
Benefits
.commonAnnotationsdo annotate all the resources which is not always optimal. Some examples is when you plan to use applicaztions like skupper when annotate Services may cause many issues.Possible drawbacks
None
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm