[bitnami/discourse] Use unicorn instead of passenger #2355

wzrdtales · 2022-08-08T19:32:43Z

Original https://github.com/bitnami/bitnami-docker-discourse/pull/234

discourse lately removed the setting from the UI, this image doesn't really work properly without disabling this option currently.

Signed-off-by: Tobias Gurtzick [email protected]

right now requires to set serve_static_assets = true

important info from previous ticket:

the docker-compose seems to be outdated and deviates from the helm chart.
The helm chart sets already

  - DISCOURSE_PORT_NUMBER=8080
  - DISCOURSE_EXTERNAL_HTTP_PORT_NUMBER=80

These two variables, and adding those to the docker-compose lets it run just fine.

Signed-off-by: Tobias Gurtzick <[email protected]>

wzrdtales · 2022-08-08T19:32:57Z

/cc @carrodher

wzrdtales · 2022-08-08T19:33:42Z

/cc @migruiz4 @belmeopmenieuwesim

gongomgra · 2022-08-16T10:03:13Z

@migruiz4, as you have more context than me with this PR and it looks like you have already started checking the changes in the associated issue, I'm handling it over to you so you can take the best decision.

migruiz4

Hi @wzrdtales,

Please take a look at my comments below.

I have suggested several changes, including the removal of runit as it does not seem necessary to run unicorn.

migruiz4 · 2022-08-26T08:01:49Z

bitnami/discourse/2/debian-11/rootfs/opt/bitnami/scripts/discourse-env.sh

+DISCOURSE_SERVE_STATIC_ASSETS="${DISCOURSE_SERVE_STATIC_ASSETS:-true}"
+export DISCOURSE_SERVE_STATIC_ASSETS="${DISCOURSE_SERVE_STATIC_ASSETS:-true}"


Please move these lines under the # Discourse configuration comment

migruiz4 · 2022-08-26T08:03:51Z

bitnami/discourse/2/debian-11/Dockerfile

@@ -17,7 +17,7 @@ RUN . /opt/bitnami/scripts/libcomponent.sh && component_unpack "node" "14.20.0-1
 RUN . /opt/bitnami/scripts/libcomponent.sh && component_unpack "git" "2.37.1-1" --checksum 39ea3040baa552b4760c1100a3713f86493620c0a74121c1ceba50fe17341878
 RUN . /opt/bitnami/scripts/libcomponent.sh && component_unpack "brotli" "1.0.9-151" --checksum ba4c4d26d232f8d91d1143078a633ba7c5ae33f5c4182684400ffb7bbc0ed262
 RUN . /opt/bitnami/scripts/libcomponent.sh && component_unpack "discourse" "2.8.7-1" --checksum bd120eab1a7403e691f608f57b574a9782391fe1c4a46ce40752cfa560f922c2
-RUN apt-get update && apt-get upgrade -y && \
+RUN apt-get update && apt-get upgrade -y && apt-get install sudo runit -y && \


I would prefer not installing runit in a container unless it is strictly necessary.

I have performed some tests using the changes suggested in this review and I was able to use unicorn without runit.

if you change something that supposedly is working, then it would be nice if you just attach it. I don't have time to test a foreign theory. When we tested it didn't work without runit to run as non-root

migruiz4 · 2022-08-26T08:04:29Z

bitnami/discourse/2/debian-11/rootfs/opt/bitnami/scripts/discourse/run.sh

    "-p" "$DISCOURSE_PORT_NUMBER"
-    "--spawn-method" "$DISCOURSE_PASSENGER_SPAWN_METHOD"
+    "-c" "config/unicorn.conf.rb"
 )

 # Append extra flags specified via environment variables


Please rename PASSENGER env variables.

migruiz4 · 2022-08-26T08:05:58Z

bitnami/discourse/2/debian-11/rootfs/opt/bitnami/scripts/discourse-env.sh

@@ -92,6 +93,8 @@ export DISCOURSE_CONF_FILE="${DISCOURSE_BASE_DIR}/config/discourse.conf"
 export PATH="${BITNAMI_ROOT_DIR}/common/bin:${BITNAMI_ROOT_DIR}/brotli/bin:${BITNAMI_ROOT_DIR}/git/bin:${PATH}"

 # Discourse persistence configuration
+DISCOURSE_SERVE_STATIC_ASSETS="${DISCOURSE_SERVE_STATIC_ASSETS:-true}"
+export DISCOURSE_SERVE_STATIC_ASSETS="${DISCOURSE_SERVE_STATIC_ASSETS:-true}"
 export DISCOURSE_VOLUME_DIR="${BITNAMI_VOLUME_DIR}/discourse"
 export DISCOURSE_DATA_TO_PERSIST="${DISCOURSE_DATA_TO_PERSIST:-plugins public/backups public/uploads}"



Unicorn will fail to start if we use the current default value for DISCOURSE_PORT_NUMBER, please change the value from 3000 to 8080.

export DISCOURSE_PORT_NUMBER="${DISCOURSE_PORT_NUMBER:-8080}"

In addition, please replace the ports value at docker-compose.yaml.

migruiz4 · 2022-08-26T08:07:08Z

bitnami/discourse/2/debian-11/rootfs/opt/bitnami/scripts/discourse/run.sh

-    "bundle" "exec" "passenger" "start"
-    "--user" "$DISCOURSE_DAEMON_USER"
-    "-e" "$DISCOURSE_ENV"
+    chpst -u "$DISCOURSE_DAEMON_USER" -U "$DISCOURSE_DAEMON_USER" "bundle" "exec" "config/unicorn_launcher"


No need to use chpst if runit won't be used

Suggested change

chpst -u "$DISCOURSE_DAEMON_USER" -U "$DISCOURSE_DAEMON_USER" "bundle" "exec" "config/unicorn_launcher"

"bundle" "exec" "config/unicorn_launcher"

migruiz4 · 2022-08-26T08:09:02Z

bitnami/discourse/2/debian-11/rootfs/opt/bitnami/scripts/discourse/run.sh

@@ -33,4 +32,4 @@ if [[ -n "$DISCOURSE_PASSENGER_EXTRA_FLAGS" ]]; then
 fi

 info "** Starting Discourse **"
-exec "${cmd[@]}" "$@"
+USER=$DISCOURSE_DAEMON_USER exec "${cmd[@]}" "$@"


To avoid running the process as root, use the following instead:

Suggested change

USER=$DISCOURSE_DAEMON_USER exec "${cmd[@]}" "$@"

if am_i_root; then

exec gosu "$DISCOURSE_DAEMON_USER" "${cmd[@]}"

else

exec "${cmd[@]}"

fi

github-actions · 2022-09-11T01:33:43Z

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

github-actions · 2022-09-16T01:38:15Z

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

belmeopmenieuwesim · 2023-10-16T10:22:44Z

this stuff is unmaintained. If I were you I would look elsewhere.

wzrdtales · 2023-10-16T10:47:50Z

yeah, we're maintaining it until today ourselves in a forked image... .

github-actions · 2023-11-01T01:25:25Z

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

jacobowitz · 2023-11-17T11:33:44Z

@migruiz4
Can I assume that you will pick up this PR eventually? I need this PR merged as well. If nobody is picking this one up, I'd try, but I am lacking a lot of context here so I would rather not do it.

migruiz4 · 2023-11-17T11:46:47Z

Hi @jacobowitz,

We have an internal task to study if migrating bitnami/unicorn from passenger to unicorn is viable or not, but as we have to deal with other priorities it is currently in our Backlog.

As I mentioned in my review, the usage of runit in our images is a strong no from my side.

github-actions · 2023-12-03T01:26:54Z

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

github-actions · 2023-12-09T01:24:15Z

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

bitnami discourse, use unicorn instead...

d78f444

Signed-off-by: Tobias Gurtzick <[email protected]>

bitnami-bot assigned rafariossaa Aug 8, 2022

bitnami-bot requested a review from rafariossaa August 8, 2022 19:33

bitnami-bot added the triage Triage is needed label Aug 8, 2022

recena changed the title ~~Use unicorn instead of passenger~~ [bitnami/discourse] Use unicorn instead of passenger Aug 9, 2022

rafariossaa added the discourse label Aug 11, 2022

bitnami-bot added in-progress and removed triage Triage is needed labels Aug 11, 2022

bitnami-bot unassigned rafariossaa Aug 11, 2022

bitnami-bot removed the request for review from rafariossaa August 11, 2022 07:10

bitnami-bot assigned gongomgra Aug 11, 2022

bitnami-bot requested a review from gongomgra August 11, 2022 07:10

gongomgra requested review from migruiz4 and removed request for gongomgra August 16, 2022 10:01

gongomgra assigned migruiz4 Aug 16, 2022

gongomgra removed their assignment Aug 16, 2022

migruiz4 requested changes Aug 26, 2022

View reviewed changes

github-actions bot added the stale 15 days without activity label Sep 11, 2022

karpfediem mentioned this pull request Sep 11, 2022

[bitnami/discourse] Intermittent slow page load times for Discourse bitnami/charts#8746

Closed

github-actions bot closed this Sep 16, 2022

javsalgar reopened this Oct 11, 2023

github-actions bot added in-progress and removed triage Triage is needed labels Oct 11, 2023

bitnami-bot unassigned migruiz4 Oct 11, 2023

bitnami-bot removed the request for review from migruiz4 October 11, 2023 10:04

github-actions bot added triage Triage is needed and removed in-progress labels Oct 11, 2023

bitnami-bot assigned CeliaGMqrz Oct 11, 2023

bitnami-bot requested a review from CeliaGMqrz October 11, 2023 10:04

github-actions bot removed the stale 15 days without activity label Oct 12, 2023

github-actions bot added the stale 15 days without activity label Nov 1, 2023

CeliaGMqrz removed the stale 15 days without activity label Nov 2, 2023

CeliaGMqrz assigned migruiz4 Nov 2, 2023

github-actions bot added the stale 15 days without activity label Dec 3, 2023

github-actions bot added the solved label Dec 9, 2023

bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Dec 9, 2023

bitnami-bot closed this Dec 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bitnami/discourse] Use unicorn instead of passenger #2355

[bitnami/discourse] Use unicorn instead of passenger #2355

wzrdtales commented Aug 8, 2022

wzrdtales commented Aug 8, 2022

wzrdtales commented Aug 8, 2022

gongomgra commented Aug 16, 2022

migruiz4 left a comment

migruiz4 Aug 26, 2022

migruiz4 Aug 26, 2022

wzrdtales Oct 13, 2022

migruiz4 Aug 26, 2022

migruiz4 Aug 26, 2022

migruiz4 Aug 26, 2022

migruiz4 Aug 26, 2022

github-actions bot commented Sep 11, 2022

github-actions bot commented Sep 16, 2022

belmeopmenieuwesim commented Oct 16, 2023

wzrdtales commented Oct 16, 2023

github-actions bot commented Nov 1, 2023

jacobowitz commented Nov 17, 2023

migruiz4 commented Nov 17, 2023

github-actions bot commented Dec 3, 2023

github-actions bot commented Dec 9, 2023

		DISCOURSE_SERVE_STATIC_ASSETS="${DISCOURSE_SERVE_STATIC_ASSETS:-true}"
		export DISCOURSE_SERVE_STATIC_ASSETS="${DISCOURSE_SERVE_STATIC_ASSETS:-true}"

	chpst -u "$DISCOURSE_DAEMON_USER" -U "$DISCOURSE_DAEMON_USER" "bundle" "exec" "config/unicorn_launcher"
	"bundle" "exec" "config/unicorn_launcher"

[bitnami/discourse] Use unicorn instead of passenger #2355

[bitnami/discourse] Use unicorn instead of passenger #2355

Conversation

wzrdtales commented Aug 8, 2022

wzrdtales commented Aug 8, 2022

wzrdtales commented Aug 8, 2022

gongomgra commented Aug 16, 2022

migruiz4 left a comment

Choose a reason for hiding this comment

migruiz4 Aug 26, 2022

Choose a reason for hiding this comment

migruiz4 Aug 26, 2022

Choose a reason for hiding this comment

wzrdtales Oct 13, 2022

Choose a reason for hiding this comment

migruiz4 Aug 26, 2022

Choose a reason for hiding this comment

migruiz4 Aug 26, 2022

Choose a reason for hiding this comment

migruiz4 Aug 26, 2022

Choose a reason for hiding this comment

migruiz4 Aug 26, 2022

Choose a reason for hiding this comment

github-actions bot commented Sep 11, 2022

github-actions bot commented Sep 16, 2022

belmeopmenieuwesim commented Oct 16, 2023

wzrdtales commented Oct 16, 2023

github-actions bot commented Nov 1, 2023

jacobowitz commented Nov 17, 2023

migruiz4 commented Nov 17, 2023

github-actions bot commented Dec 3, 2023

github-actions bot commented Dec 9, 2023