-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql] README was not reflecting the start scripts #45066
Conversation
The start scripts use POSTGRESQL_INITDB_WAL_DIR instead of POSTGRESQL_INITDB_WALDIR. This just fixes the README.md to reflect the code. Signed-off-by: Dominik Hannen <[email protected]>
Hi @dhxgit, Could you be so kind as to tell us why this change? Could you add some documentation? |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
hi, as stated this fixes the documentation(readme), which at the moment does not reflect the underlying code. atm the documentation says to set the env var named: POSTGRESQL_INITDB_WALDIR This is wrong as the startup script of the container is checking for POSTGRESQL_INITDB_WAL_DIR. if you would setup the container according to the readme, you would not be able to set the waldir properly. see startup script in question here: I stumbled over this because i was wondering why setting the wal_dir did not work, when i tried to set it up according to the readme. I hope this clarifies the problem. fixing it in the readme is the most sensible approach, as fixing the code to make the readme correct would be a bigger change, which would break existing configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dhxgit,
You are right, thanks for the contribution!!
LGTM!
Description of the change
The start scripts use POSTGRESQL_INITDB_WAL_DIR instead of POSTGRESQL_INITDB_WALDIR.
This just fixes the README.md to reflect the code.
Benefits
The README.md will no longer be wrong.
Possible drawbacks
None
Applicable issues
None (Could also file an issue, but this is a really small and obvious fix I believe)