-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql] Introduces environment variable POSTGRESQL_DEFAULT_TRANSACTION_ISOLATION to change the global default transaction isolation level #47819
Conversation
f197394
to
9542b3f
Compare
…ON (bitnami#25013) Signed-off-by: Florian Kamella <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for adding this.
This new environment variable should be also added to postgresql-env.sh
Signed-off-by: Florian Kamella <[email protected]>
Hi @rafariossaa Thanks for the review. I updated postgresql-env.sh in df9866a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
The change introduces a new environment variable
POSTGRESQL_DEFAULT_TRANSACTION_ISOLATION
to the bitnami postgres images. The environment variable can be used to change the global default for the transaction isolation level in postgresql.The change fixes #25013
It's currently not possible to change the default transaction isolation level using the
POSTGRESQL_EXTRA_FLAGS
if the desired isolation level's name contains a space.containers/bitnami/postgresql/15/debian-11/rootfs/opt/bitnami/scripts/postgresql/run.sh
Lines 19 to 22 in 218f537
If we'd omit the
-r
flag given to read in it would work with escaping the space in "repeatable read" with a backslash (repeatable\ read
). However that this is not possible to preserve backwards compatibility since it could break existing solutions.Benefits
It preserves backwards compatibility but still offers a possibility to change the global default transaction isolation level.
Possible drawbacks
It does not use the existing environment variable
POSTGRESQL_EXTRA_FLAGS
.Applicable issues
--
Additional information
I verified the change is correct using the below method.
For each folder in
do
docker build -t postgres_tmp .