-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional binding of listening address. #50033
Conversation
…e to disable IPv6 or IPv4 explicitly, since default is to listen on both. Ref: - https://www.openldap.org/doc/admin25/security.html
Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines. Feel free to reach out if you have any questions or need assistance with the signing process. |
Hi, I believe my commits are digitally signed with GPG: And it's verifiable as me: https://keys.openpgp.org/search?q=F1234C5BA67C59DF I'm used to using github's Squash and Merge function, if you prefer I do it client side I could arrange that. And if you feel extremely strongly about a commit message saying it's signed off rather than digitally signing off with a GPG key, I could look in to that - but that might take longer time as I'd have to revert my commits. |
The DCO check is failing, see https://github.com/bitnami/containers/pull/50033/checks?check_run_id=17137035285. In that link, you can find more info about the issue and how to solve it |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Description of the change
This enables the ability to disable/enable IPv6 or IPv4 independently of each other, since default is to listen on both.
Benefits
This allows us to follow some recommendations from https://www.openldap.org/doc/admin25/security.html as well as use the container on IPv6 disabled host machines.