Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional binding of listening address. #50033

Closed
wants to merge 3 commits into from

Conversation

Torxed
Copy link

@Torxed Torxed commented Sep 26, 2023

Description of the change

This enables the ability to disable/enable IPv6 or IPv4 independently of each other, since default is to listen on both.

Benefits

This allows us to follow some recommendations from https://www.openldap.org/doc/admin25/security.html as well as use the container on IPv6 disabled host machines.

@github-actions github-actions bot added the triage Triage is needed label Sep 26, 2023
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@Torxed
Copy link
Author

Torxed commented Sep 26, 2023

Hi, I believe my commits are digitally signed with GPG:
screenshot

And it's verifiable as me: https://keys.openpgp.org/search?q=F1234C5BA67C59DF
This should be stronger than any commit message or comment stating it's signed off by someone.

I'm used to using github's Squash and Merge function, if you prefer I do it client side I could arrange that. And if you feel extremely strongly about a commit message saying it's signed off rather than digitally signing off with a GPG key, I could look in to that - but that might take longer time as I'd have to revert my commits.

@Torxed Torxed marked this pull request as ready for review September 27, 2023 07:00
@carrodher
Copy link
Member

The DCO check is failing, see https://github.com/bitnami/containers/pull/50033/checks?check_run_id=17137035285. In that link, you can find more info about the issue and how to solve it

@github-actions
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Oct 13, 2023
@github-actions
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openldap solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants