[bitnami/mastodon] Fix initJob.createAdmin is true and the init container never finish #51111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See bitnami/charts#14485. If the admin user/email is already exist, the current code exists with error instead of skipping account creation, because the testing expects "been taken" string from tootctl command, however tootctl in the 4.2.0 release that I tested, return different string: ``` res=$(tootctl accounts create "$MASTODON_ADMIN_USERNAME" --email "$MASTODON_ADMIN_EMAIL" "--confirmed" "--role" "Owner") $ echo $res Failure/Error: email taken Failure/Error: account.username taken ``` Simply change the testing string to "taken" fix this issue. Signed-off-by: Xueshan Feng <[email protected]>
fevisera
changed the title
fevisera
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bitnami/charts#14485.
If the admin user/email is already exist, the current code exists with error instead of skipping account creation, because the testing expects "been taken" string from tootctl command, however tootctl in the 4.2.0 release that I tested, return different string:
Simply change the testing string to "taken" fix this issue.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information