[bitnami/openldap] Correct naming and location for some organization units

[barsikus007]

Description of the change

Fix of #19716 issue

Benefits

Correct and predictable location of groups organization unit (E.g. https://hub.docker.com/r/wheelybird/ldap-user-manager image expect to see groups in separate ou than users)

Possible drawbacks

It could break some configs, which is targeted to previous schema and env variables

Applicable issues

• fixes LDAP groups should be in a different OU than users #19716

Additional information

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[barsikus007]

hey?

[carrodher]

Hi, please note this PR is marked as Draft, if it is ready to be reviewed, could you please mark it as Ready for review?

[barsikus007]

Oh I get it

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[migruiz4]

Hi @barsikus007,

Thank you very much for your contribution, but I'm worried about how this change would affect existing users.

Do you think you could make this change backward-compatible? For example, instead of removing it, you could set LDAP_USER_OU/LDAP_GROUP_OU to LDAP_USER_DC if it was set and warn users about that environment variable being deprecated in favor of the new ones.

That way, the image functionality won't be affected and users will have time to modify their deployments, so we can safely remove the deprecated setting in a future release.

[barsikus007]

Okay, but how to notify users about changes?

[migruiz4]

Please take a look at my suggestions

[migruiz4]

As in my suggestion, please keep the value LDAP_USER_DC but remove its default value.

Then, for LDAP_USER_OU and LDAP_GROUP_OU it will have the following priorities:

1. Value provided in LDAP_USER_OU/LDAP_GROUP_OU
2. If no value provided and LDAP_USER_DC, use value in LDAP_USER_DC.
3. If neither LDAP_USER_OU/LDAP_GROUP_OU or LDAP_USER_DC provided, then use default values user/group.

Suggested change

	export LDAP_USER_OU="${LDAP_USER_OU:-users}"
	export LDAP_GROUP_OU="${LDAP_GROUP_OU:-groups}"
	export LDAP_USER_DC="${LDAP_USER_DC:-}"
	export LDAP_USER_OU="${LDAP_USER_OU:-${LDAP_USER_DC:-users}}"
	export LDAP_GROUP_OU="${LDAP_GROUP_OU:-${LDAP_USER_DC:-groups}}"

Then, around line 174, inside ldap_validate add the following message:

if [[ -n "$LDAP_USER_DC" ]]; then
    warn "The env variable 'LDAP_USER_DC' has been deprecated and will be removed in a future release. Please use 'LDAP_USER_OU' and 'LDAP_GROUP_OU' instead."
fi

[migruiz4]

Finally, in the README.md, you could also warn about the deprecation:

* `LDAP_USER_OU`: Name for the user's organizational unit. Default: **users**
* `LDAP_GROUP_OU`: Name for the group's organizational unit. Default: **groups**
* `LDAP_USER_DC`: DC for the users' organizational unit. **DEPRECATED** Please use `LDAP_USER_OU` and `LDAP_GROUP_OU` instead.

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[github-actions]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.