[bitnami/openldap] feat: pldap and pldaps support #70999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flags - Reduce dupes - Allow advanced logic for each flag arguments Signed-off-by: Arano-kai <[email protected]>
Support for 'proxied LDAP' and 'proxied LDAP over SSL'. Read 'https://www.openldap.org/doc/admin26/runningslapd.html#Command-Line%20Options' for additional info. Signed-off-by: Arano-kai <[email protected]>
When the debugging is on, show what will actually run Signed-off-by: Arano-kai <[email protected]>
Assert that port related values are positive int Signed-off-by: Arano-kai <[email protected]>
Arano-kai
force-pushed
the
feature/proxy_protocol
branch
from
0bdea94 to
9ef7459
Compare
carrodher
added
verify
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Hi @Arano-kai, sorry for the late reply. I will review the PR and I will get back to you soon. Thank you for your contribution and patience! |
andresbono
reviewed
Sep 3, 2024
bitnami/openldap/2.6/debian-12/rootfs/opt/bitnami/scripts/openldap/run.sh
Show resolved
Hide resolved
bitnami/openldap/2.6/debian-12/rootfs/opt/bitnami/scripts/openldap/run.sh
Show resolved
Hide resolved
bitnami/openldap/2.6/debian-12/rootfs/opt/bitnami/scripts/openldap/run.sh
Show resolved
Hide resolved
bitnami/openldap/2.6/debian-12/rootfs/opt/bitnami/scripts/openldap/run.sh
Show resolved
Hide resolved
bitnami/openldap/2.6/debian-12/rootfs/opt/bitnami/scripts/openldap/run.sh
Show resolved
Hide resolved
andresbono
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Ability to enable pldap(s) protocols.
Benefits
The pldap(s) is required when LDAP servers is run behind LB proxy. The proxy protocol v2 allow reveal the real client IP on LDAP server side in such setup.
Possible drawbacks
Previous deployments not affected, this feature is disabled by default.
In new deployments that want use pldap(s) and replication, user must provide additional config to move proxy protocol enabled ports to non-default values, since replication can't run on pldap(s).
Applicable issues
None.
Additional information
The /opt/bitnami/scripts/openldap/run.sh are refactored to allow independent configuration and advanced logic for each startup flag. This changes are BASH specific and require additional patch if container moves to other shell.
Additional check for LDAP_PORT_NUMBER and LDAP_LDAPS_PORT_NUMBER is set, which should not affect valid deployments.